patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: fuel_gauge: max17048: Fix overflow when calculating voltage

Browse source 
Annotate the calculation with type casts to force
promotion to uint32_t and then cast back down
to uint16_t for the return. This solves the issue
with invalid voltage (mV) values being returned
due to overflow during the conversion from the
register value on the max17048 chip.

Signed-off-by: Martin Calsyn <martin.calsyn@outcomex.com.au>
This commit is contained in:
Martin Calsyn 2023-10-07 13:44:34 +02:00 committed by Fabio Baltieri
parent 49d4ad9315
commit 12c0204b60
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/fuel_gauge/max17048/max17048.c
View file

@ -90,7 +90,7 @@ int max17048_voltage(const struct device *i2c_dev, uint16_t *response)
* milli volts instead of volts.
*/
*response = *response * 78125 / 1000000;
*response = (uint16_t)((uint32_t)*response * 78125L / 1000000L);
return 0;
}