patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers/modem/gsm_ppp.c: Remove direct call to PPP API

Browse source 
This commit removes the direct calls of the PPP API of the
network device used by gsm_ppp.c

These calls are now performed by the L2 PPP interface when it
is brought up or down using net_if_up() or net_if_down()

Signed-off-by: Bjarki Arge Andreasen <bjarkix123@gmail.com>
This commit is contained in:
Bjarki Arge Andreasen 2023-08-09 19:27:11 +02:00 committed by Fabio Baltieri
parent 023d0e9dc0
commit 12e79ca4ce
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/modem/gsm_ppp.c
View file

@ -615,23 +615,13 @@ static struct net_if *ppp_net_if(void)
static void set_ppp_carrier_on(struct gsm_modem *gsm)
{
const struct device *ppp_dev = device_get_binding(CONFIG_NET_PPP_DRV_NAME);
const struct ppp_api *api;
struct net_if *iface = gsm->iface;
int ret;
if (ppp_dev == NULL) {
LOG_ERR("Cannot find PPP %s!", CONFIG_NET_PPP_DRV_NAME);
return;
}
api = (const struct ppp_api *)ppp_dev->api;
ret = api->start(ppp_dev);
if (ret < 0) {
LOG_ERR("ppp start returned %d", ret);
}
net_if_up(iface);
}
@ -1171,8 +1161,6 @@ unlock:
void gsm_ppp_stop(const struct device *dev)
{
const struct device *ppp_dev = device_get_binding(CONFIG_NET_PPP_DRV_NAME);
const struct ppp_api *api = (const struct ppp_api *)ppp_dev->api;
struct gsm_modem *gsm = dev->data;
struct net_if *iface = gsm->iface;
struct k_work_sync work_sync;
@ -1187,8 +1175,6 @@ void gsm_ppp_stop(const struct device *dev)
(void)k_work_cancel_delayable_sync(&gsm->rssi_work_handle, &work_sync);
}
api->stop(ppp_dev);
gsm_ppp_lock(gsm);
/* wait for the interface to be properly down */