patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: led: pca9633: disable allcall

Browse source 
The PCA9633 i2c LED controller offers an All Call address in its nominal
operation, allowing simultaneous communication with all instances present
on the same i2c bus. The default address is 0x70. While this functionality
is convenient, it is possible that the board uses another i2c component
that also uses this address (for example, the shtcx). In such cases, the
address conflict prevents the proper functioning of the system.

The idea is to add a "disable-allcall" property to the device tree. If this
option is present, the initialization of the PCA9633 forces the bit 0
(ALLCALL) to be set to false, thereby disabling this function. It is
necessary to add this property to all PCA9633 devices on the bus to free up
the address 0x70.

Signed-off-by: Steve Jacot-Guillarmod <steve@piziwate.net>
This commit is contained in:
Steve Jacot-Guillarmod 2023-07-28 09:40:08 +02:00 committed by Fabio Baltieri
parent af953a1d07
commit 13d74677ba
2 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
drivers/led/pca9633.c
View file

@ -37,6 +37,7 @@ LOG_MODULE_REGISTER(pca9633);
#define PCA9633_LEDOUT 0x08 #define PCA9633_LEDOUT 0x08
/* PCA9633 mode register 1 */ /* PCA9633 mode register 1 */
#define PCA9633_MODE1_ALLCAL 0x01 /* All Call Address enabled */
#define PCA9633_MODE1_SLEEP 0x10 /* Sleep Mode */ #define PCA9633_MODE1_SLEEP 0x10 /* Sleep Mode */
/* PCA9633 mode register 2 */ /* PCA9633 mode register 2 */
#define PCA9633_MODE2_DMBLNK 0x20 /* Enable blinking */ #define PCA9633_MODE2_DMBLNK 0x20 /* Enable blinking */
@ -45,6 +46,7 @@ LOG_MODULE_REGISTER(pca9633);
struct pca9633_config { struct pca9633_config {
struct i2c_dt_spec i2c; struct i2c_dt_spec i2c;
bool disable_allcall;
}; };
struct pca9633_data { struct pca9633_data {
@ -192,11 +194,16 @@ static int pca9633_led_init(const struct device *dev)
return -ENODEV; return -ENODEV;
} }
/* Take the LED driver out from Sleep mode. */ /*
if (i2c_reg_update_byte_dt(&config->i2c, * Take the LED driver out from Sleep mode and disable All Call Address
PCA9633_MODE1, * if specified in DT.
PCA9633_MODE1_SLEEP, */
~PCA9633_MODE1_SLEEP)) { if (i2c_reg_update_byte_dt(
&config->i2c, PCA9633_MODE1,
config->disable_allcall ? PCA9633_MODE1_SLEEP | PCA9633_MODE1_ALLCAL
: PCA9633_MODE1_SLEEP,
config->disable_allcall ? ~(PCA9633_MODE1_SLEEP | PCA9633_MODE1_ALLCAL)
: ~PCA9633_MODE1_SLEEP)) {
LOG_ERR("LED reg update failed"); LOG_ERR("LED reg update failed");
return -EIO; return -EIO;
} }
@ -218,7 +225,8 @@ static const struct led_driver_api pca9633_led_api = {
#define PCA9633_DEVICE(id) \ #define PCA9633_DEVICE(id) \
static const struct pca9633_config pca9633_##id##_cfg = { \ static const struct pca9633_config pca9633_##id##_cfg = { \
.i2c = I2C_DT_SPEC_INST_GET(id) \ .i2c = I2C_DT_SPEC_INST_GET(id), \
.disable_allcall = DT_INST_PROP(id, disable_allcall), \
}; \ }; \
static struct pca9633_data pca9633_##id##_data; \ static struct pca9633_data pca9633_##id##_data; \
\ \

5
dts/bindings/led/nxp,pca9633.yaml
View file

@ -3,3 +3,8 @@ description: NXP PCA9633 LED
compatible: "nxp,pca9633" compatible: "nxp,pca9633"
include: i2c-device.yaml include: i2c-device.yaml
properties:
disable-allcall:
type: boolean
description: Disable response to LED All Call address request