From 16d723ee1be9bcb07e44eefaeaa2d2e8786010ce Mon Sep 17 00:00:00 2001 From: Fabio Baltieri Date: Thu, 26 Jan 2023 17:03:13 +0000 Subject: [PATCH] scripts: set_assignee: don't skip assignment on too many labels The set assignee script currently exits if there's too many labels associated with a PR. Change that to just skip the label assignment, but continue on to assign a maintainer based on the most relevant area. Tested with: ./scripts/set_assignees.py -v --dry-run -P 52716 Signed-off-by: Fabio Baltieri --- scripts/set_assignees.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/set_assignees.py b/scripts/set_assignees.py index a636098149..09571ab020 100755 --- a/scripts/set_assignees.py +++ b/scripts/set_assignees.py @@ -80,9 +80,6 @@ def process_pr(gh, maintainer_file, number): ac = dict(sorted(area_counter.items(), key=lambda item: item[1], reverse=True)) log(f"Area matches: {ac}") log(f"labels: {labels}") - if len(labels) > 10: - log(f"Too many labels to be applied") - return # Create a list of collaborators ordered by the area match collab = list() @@ -143,11 +140,14 @@ def process_pr(gh, maintainer_file, number): log("+++++++++++++++++++++++++") # Set labels - if labels and len(labels) < 10: - for l in labels: - log(f"adding label {l}...") - if not args.dry_run: - pr.add_to_labels(l) + if labels: + if len(labels) < 10: + for l in labels: + log(f"adding label {l}...") + if not args.dry_run: + pr.add_to_labels(l) + else: + log(f"Too many labels to be applied") if collab: reviewers = []