patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: route: Do not access null neighbor

Browse source 
Possible null pointer dereference when looking up the nexthop
neighbor.

Coverity-CID: 190639
Fixes #12294

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2019-02-21 15:04:21 +02:00 committed by Anas Nashif
parent 5e83e919e3
commit 18f9db5381
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
subsys/net/ip/route.c
View file

@ -204,9 +204,14 @@ static struct net_nbr *nbr_nexthop_get(struct net_if *iface,
/* Note that the nexthop host must be already in the neighbor
* cache. We just increase the ref count of an existing entry.
*/
struct net_nbr *nbr = net_ipv6_nbr_lookup(iface, addr);
struct net_nbr *nbr;
nbr = net_ipv6_nbr_lookup(iface, addr);
if (nbr == NULL) {
NET_DBG("Next hop neighbor not found!");
return NULL;
}
NET_ASSERT_INFO(nbr, "Next hop neighbor not found!");
NET_ASSERT_INFO(nbr->idx != NET_NBR_LLADDR_UNKNOWN,
"Nexthop %s not in neighbor cache!",
log_strdup(net_sprint_ipv6_addr(addr)));