patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers/ethernet: Update default GPIO pin for the ENC28J60 module

Browse source 
All sample applicatons in Zephyr, using the ENC28J60 driver, set
the ETH_ENC28J60_0_GPIO_PIN Kconfig variable to 19.
However, in the Kconfig.enc28j60 file this variable is set to 24.
That default value, 24, was used only during the first iterations
of this driver and never used again.

In this patch, we set the Kconfig variable to 19 and simplify
project configuration files by removing one line.

Change-Id: I3d5fd9da04a3f10845d2a409de56f5b9c235e995
Signed-off-by: Flavio Santes <flavio.santes@intel.com>
This commit is contained in:
Flavio Santes 2017-01-15 00:32:15 -06:00 committed by Jukka Rissanen
parent 06286f93aa
commit 1c21029237
6 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/ethernet/Kconfig.enc28j60
View file

@ -58,7 +58,7 @@ config ETH_ENC28J60_0_GPIO_PORT_NAME
config ETH_ENC28J60_0_GPIO_PIN config ETH_ENC28J60_0_GPIO_PIN
int "ENC28J60C INT GPIO PIN" int "ENC28J60C INT GPIO PIN"
default 24 default 19
help help
GPIO pin number used to conect INT GPIO pin number used to conect INT

1
samples/net/dhcpv4_client/prj_arduino_101.conf
View file

@ -34,7 +34,6 @@ CONFIG_SPI_1_CS_GPIO_PIN=0
CONFIG_SYS_LOG_ETHERNET_LEVEL=1 CONFIG_SYS_LOG_ETHERNET_LEVEL=1
CONFIG_ETH_ENC28J60=y CONFIG_ETH_ENC28J60=y
CONFIG_ETH_ENC28J60_0=y CONFIG_ETH_ENC28J60_0=y
CONFIG_ETH_ENC28J60_0_GPIO_PIN=19
CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1" CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1"
CONFIG_ETH_ENC28J60_0_SPI_BUS_FREQ=2 CONFIG_ETH_ENC28J60_0_SPI_BUS_FREQ=2
CONFIG_ETH_ENC28J60_0_MAC3=0x0a CONFIG_ETH_ENC28J60_0_MAC3=0x0a

1
samples/net/dns_client/prj_arduino_101.conf
View file

@ -17,7 +17,6 @@ CONFIG_NET_NBUF_DATA_COUNT=16
# ENC28J60 Ethernet Device # ENC28J60 Ethernet Device
CONFIG_ETH_ENC28J60=y CONFIG_ETH_ENC28J60=y
CONFIG_ETH_ENC28J60_0=y CONFIG_ETH_ENC28J60_0=y
CONFIG_ETH_ENC28J60_0_GPIO_PIN=19
CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1" CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1"
CONFIG_ETH_ENC28J60_0_MAC3=0x2D CONFIG_ETH_ENC28J60_0_MAC3=0x2D
CONFIG_ETH_ENC28J60_0_MAC4=0x30 CONFIG_ETH_ENC28J60_0_MAC4=0x30

3
samples/net/echo_client/prj_arduino_101.conf
View file

@ -14,13 +14,14 @@ CONFIG_NET_IFACE_UNICAST_IPV4_ADDR_COUNT=3
CONFIG_NET_NBUF_RX_COUNT=2 CONFIG_NET_NBUF_RX_COUNT=2
CONFIG_NET_NBUF_TX_COUNT=3 CONFIG_NET_NBUF_TX_COUNT=3
CONFIG_NET_NBUF_DATA_COUNT=12 CONFIG_NET_NBUF_DATA_COUNT=12
# ENC28J60 Ethernet Device # ENC28J60 Ethernet Device
CONFIG_ETH_ENC28J60=y CONFIG_ETH_ENC28J60=y
CONFIG_ETH_ENC28J60_0=y CONFIG_ETH_ENC28J60_0=y
CONFIG_ETH_ENC28J60_0_GPIO_PIN=19
CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1" CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1"
CONFIG_ETH_ENC28J60_0_MAC3=0x2D CONFIG_ETH_ENC28J60_0_MAC3=0x2D
CONFIG_ETH_ENC28J60_0_MAC4=0x30 CONFIG_ETH_ENC28J60_0_MAC4=0x30
CONFIG_ETH_ENC28J60_0_MAC5=0x32 CONFIG_ETH_ENC28J60_0_MAC5=0x32
# Arduino 101 # Arduino 101
CONFIG_SPI=y CONFIG_SPI=y

3
samples/net/echo_server/prj_arduino_101.conf
View file

@ -14,13 +14,14 @@ CONFIG_NET_IFACE_UNICAST_IPV4_ADDR_COUNT=3
CONFIG_NET_NBUF_RX_COUNT=10 CONFIG_NET_NBUF_RX_COUNT=10
CONFIG_NET_NBUF_TX_COUNT=2 CONFIG_NET_NBUF_TX_COUNT=2
CONFIG_NET_NBUF_DATA_COUNT=12 CONFIG_NET_NBUF_DATA_COUNT=12
# ENC28J60 Ethernet Device # ENC28J60 Ethernet Device
CONFIG_ETH_ENC28J60=y CONFIG_ETH_ENC28J60=y
CONFIG_ETH_ENC28J60_0=y CONFIG_ETH_ENC28J60_0=y
CONFIG_ETH_ENC28J60_0_GPIO_PIN=19
CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1" CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1"
CONFIG_ETH_ENC28J60_0_MAC3=0x2D CONFIG_ETH_ENC28J60_0_MAC3=0x2D
CONFIG_ETH_ENC28J60_0_MAC4=0x30 CONFIG_ETH_ENC28J60_0_MAC4=0x30
CONFIG_ETH_ENC28J60_0_MAC5=0x36 CONFIG_ETH_ENC28J60_0_MAC5=0x36
# Arduino 101 # Arduino 101
CONFIG_SPI=y CONFIG_SPI=y

1
samples/net/mbedtls_dtlsclient/prj_arduino_101.conf
View file

@ -17,7 +17,6 @@ CONFIG_NET_NBUF_DATA_COUNT=12
CONFIG_ETH_ENC28J60=y CONFIG_ETH_ENC28J60=y
CONFIG_ETH_ENC28J60_0=y CONFIG_ETH_ENC28J60_0=y
CONFIG_ETH_ENC28J60_0_GPIO_PIN=19
CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1" CONFIG_ETH_ENC28J60_0_SPI_PORT_NAME="SPI_1"
CONFIG_ETH_ENC28J60_0_SPI_BUS_FREQ=2 CONFIG_ETH_ENC28J60_0_SPI_BUS_FREQ=2
CONFIG_ETH_ENC28J60_0_MAC3=0x2D CONFIG_ETH_ENC28J60_0_MAC3=0x2D