patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

doc: modules: add link to new contributor expectations page

Browse source 
Also mention that drafts reduce notification spam.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2023-03-21 23:09:02 +00:00 committed by Carles Cufí
parent 32a48f2f55
commit 209eb20056
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
doc/develop/modules.rst
View file

@ -1031,7 +1031,9 @@ module.
To avoid merging changes to master with pull request information, the pull To avoid merging changes to master with pull request information, the pull
request should be marked as ``DNM`` (Do Not Merge) or preferably a draft pull request should be marked as ``DNM`` (Do Not Merge) or preferably a draft pull
request to make sure it is not merged by mistake and to allow for the module to request to make sure it is not merged by mistake and to allow for the module to
be merged first and be assigned a permanent commit hash. Once the module is be merged first and be assigned a permanent commit hash. Drafts reduce noise by
not automatically notifying anyone until marked as "Ready for review".
Once the module is
merged, the revision will need to be changed either by the submitter or by the merged, the revision will need to be changed either by the submitter or by the
maintainer to the commit hash of the module which reflects the changes. maintainer to the commit hash of the module which reflects the changes.
@ -1088,7 +1090,8 @@ Process for submitting changes to existing modules
================================================== ==================================================
#. Submit the changes using a pull request to an existing repository following #. Submit the changes using a pull request to an existing repository following
the :ref:`contribution guidelines <contribute_guidelines>`. the :ref:`contribution guidelines <contribute_guidelines>` and
:ref:`expectations <contributor-expectations>`.
#. Submit a pull request changing the entry referencing the module into the #. Submit a pull request changing the entry referencing the module into the
:zephyr_file:`west.yml` of the main Zephyr tree with the following :zephyr_file:`west.yml` of the main Zephyr tree with the following
information: information: