patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: ieee802154: cc13xx_cc26xx{_subg}: fix reversed extended address

Browse source 
Based on the 'Technical Reference Manual' for CC13x2/CC26x2 SimpleLink
MCU family, the device contains factory pre-programmed 64-bit IEEE MAC
address for 802.15.4 radio inside two FCFG 32-bit registers:

  1. MAC_15_4_0: first 32-bit of the 64-bit IEEE MAC address
  2. MAC_15_4_1:  last 32-bit of the 64-bit IEEE MAC address

The way current version of the driver setups the address results in
incorrect bytes order (the address is reversed):

  uart:~$ ieee802154 get_ext_addr
  Extended address: AF:03:B7:25:00:4B:12:00

This fixes the problem in both drivers (also in the Sub-GHz version)
which results in use of proper EUI-64 address:

  uart:~$ ieee802154 get_ext_addr
  Extended address: 00:12:4B:00:25:B7:03:AF

IEEE MAC address was confirmed with UniFlash, nRF Sniffer for 802.15.4
and IEEE OUI database (00:12:4B is one of registered OUI for Texas
Instruments).

To prevent confusion in future, short notice about bytes order for
'mac' field in driver's data structures was also included.

Signed-off-by: Piotr Dymacz <pepe2k@gmail.com>
This commit is contained in:
Piotr Dymacz 2023-08-29 16:42:36 +02:00 committed by Carles Cufí
parent 2b8762a438
commit 22f6c87afc
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/ieee802154/ieee802154_cc13xx_cc26xx.c
View file

@ -527,7 +527,7 @@ static void ieee802154_cc13xx_cc26xx_data_init(const struct device *dev)
mac = (uint8_t *)(FCFG1_BASE + FCFG1_O_MAC_15_4_0);
}
memcpy(&drv_data->mac, mac, sizeof(drv_data->mac));
sys_memcpy_swap(&drv_data->mac, mac, sizeof(drv_data->mac));
/* Setup circular RX queue (TRM 25.3.2.7) */
memset(&drv_data->rx_entry[0], 0, sizeof(drv_data->rx_entry[0]));

2
drivers/ieee802154/ieee802154_cc13xx_cc26xx.h
View file

@ -65,7 +65,7 @@ struct ieee802154_cc13xx_cc26xx_data {
struct net_if *iface;
uint8_t mac[8];
uint8_t mac[8]; /* in big endian */
struct k_mutex tx_mutex;

2
drivers/ieee802154/ieee802154_cc13xx_cc26xx_subg.c
View file

@ -757,7 +757,7 @@ static void ieee802154_cc13xx_cc26xx_subg_data_init(
mac = (uint8_t *)(FCFG1_BASE + FCFG1_O_MAC_15_4_0);
}
memcpy(&drv_data->mac, mac, sizeof(drv_data->mac));
sys_memcpy_swap(&drv_data->mac, mac, sizeof(drv_data->mac));
/* Setup circular RX queue (TRM 25.3.2.7) */
ieee802154_cc13xx_cc26xx_subg_setup_rx_buffers(drv_data);

2
drivers/ieee802154/ieee802154_cc13xx_cc26xx_subg.h
View file

@ -36,7 +36,7 @@ struct ieee802154_cc13xx_cc26xx_subg_data {
RF_Object rf_object;
struct net_if *iface;
uint8_t mac[8];
uint8_t mac[8]; /* in big endian */
struct k_mutex tx_mutex;