patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: stm32: SPI: cannot send several buffers if frame size is 16 bits

Browse source 
spi_context_get_next_buf must not divide `len` by `dfs` because, in SPI,
buffer lengths are given in units of data (in this case, 16 bits), not in
bytes.

Signed-off-by: Daniel Gaston Ochoa <dgastonochoa@gmail.com>
This commit is contained in:
Daniel Gaston Ochoa 2023-04-03 18:01:20 +01:00 committed by Carles Cufí
parent f12ffaea1a
commit 3003777810
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/spi/spi_context.h
View file

@ -270,13 +270,12 @@ static inline void spi_context_unlock_unconditionally(struct spi_context *ctx)
static inline void *spi_context_get_next_buf(const struct spi_buf **current,
size_t *count,
size_t *buf_len,
uint8_t dfs)
size_t *buf_len)
{
/* This loop skips zero-length buffers in the set, if any. */
while (*count) {
if (((*current)->len / dfs) != 0) {
*buf_len = (*current)->len / dfs;
if (((*current)->len) != 0) {
*buf_len = (*current)->len;
return (*current)->buf;
}
++(*current);
@ -299,13 +298,13 @@ void spi_context_buffers_setup(struct spi_context *ctx,
ctx->tx_count = ctx->current_tx ? tx_bufs->count : 0;
ctx->tx_buf = (const uint8_t *)
spi_context_get_next_buf(&ctx->current_tx, &ctx->tx_count,
&ctx->tx_len, dfs);
&ctx->tx_len);
ctx->current_rx = rx_bufs ? rx_bufs->buffers : NULL;
ctx->rx_count = ctx->current_rx ? rx_bufs->count : 0;
ctx->rx_buf = (uint8_t *)
spi_context_get_next_buf(&ctx->current_rx, &ctx->rx_count,
&ctx->rx_len, dfs);
&ctx->rx_len);
ctx->sync_status = 0;
@ -341,7 +340,7 @@ void spi_context_update_tx(struct spi_context *ctx, uint8_t dfs, uint32_t len)
ctx->tx_buf = (const uint8_t *)
spi_context_get_next_buf(&ctx->current_tx,
&ctx->tx_count,
&ctx->tx_len, dfs);
&ctx->tx_len);
} else if (ctx->tx_buf) {
ctx->tx_buf += dfs * len;
}
@ -388,7 +387,7 @@ void spi_context_update_rx(struct spi_context *ctx, uint8_t dfs, uint32_t len)
ctx->rx_buf = (uint8_t *)
spi_context_get_next_buf(&ctx->current_rx,
&ctx->rx_count,
&ctx->rx_len, dfs);
&ctx->rx_len);
} else if (ctx->rx_buf) {
ctx->rx_buf += dfs * len;
}