patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

net: tcp: Make sure we shift by less then bit width

Browse source 
Shifting "timeout <<= conn->zwp_retries" by more then 63 bits results in
undefined behaviour.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
This commit is contained in:
Andrei Emeltchenko 2023-05-17 14:50:58 +03:00 committed by Carles Cufí
parent 42b121ee95
commit 303a0af68f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subsys/net/ip/tcp.c
View file

@ -1404,8 +1404,8 @@ static void tcp_send_zwp(struct k_work *work)
if (conn->send_win == 0) {
uint64_t timeout = TCP_RTO_MS;
/* Make sure the retry counter does not overflow. */
if (conn->zwp_retries < UINT8_MAX) {
/* Make sure the bitwise shift does not result in undefined behaviour */
if (conn->zwp_retries < 63) {
conn->zwp_retries++;
}