patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

tc_util: protect macro arg expansion

Browse source 
Calling TC_END_REPORT(complex_expression) might have side effects when
complex_expression is later put inside (result == TC_PASS? A : B)
evaluation, because result will be replaced verbatim.

To avoid operator assignment order changing things, protect
replacement of result by adding parenthesis.

Change-Id: I8fd07d97d4b49b4cd48a1c6ad345bf49fb2537b5
Signed-off-by: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
This commit is contained in:
Inaky Perez-Gonzalez 2016-10-27 17:19:31 -07:00 committed by Andrew Boie
parent c20b48b9ed
commit 3ad37fbebc
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tests/include/tc_util.h
View file

@ -80,14 +80,14 @@
#define TC_END(result, fmt, ...) PRINT_DATA(fmt, ##__VA_ARGS__)
/* prints result and the function name */
#define _TC_END_RESULT(result, func) \
do { \
PRINT_LINE; \
TC_END(result, "%s - %s.\n", \
result == TC_PASS ? PASS : FAIL, func); \
#define _TC_END_RESULT(result, func) \
do { \
PRINT_LINE; \
TC_END(result, "%s - %s.\n", \
(result) == TC_PASS ? PASS : FAIL, func); \
} while (0)
#define TC_END_RESULT(result) \
_TC_END_RESULT(result, __func__)
_TC_END_RESULT((result), __func__)
#define TC_END_REPORT(result) \
do { \
@ -95,7 +95,7 @@
TC_PRINT_RUNID; \
TC_END(result, \
"PROJECT EXECUTION %s\n", \
result == TC_PASS ? "SUCCESSFUL" : "FAILED"); \
(result) == TC_PASS ? "SUCCESSFUL" : "FAILED"); \
} while (0)
#endif /* __TC_UTIL_H__ */