patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: can: reset statistics when starting the CAN controller

Browse source 
Reset CAN controller statistics when starting the CAN controller.

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
This commit is contained in:
Henrik Brix Andersen 2023-03-14 13:28:36 +01:00 committed by Carles Cufí
parent b079316b4e
commit 3c89bbf876
4 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/can/can_mcux_flexcan.c
View file

@ -204,7 +204,8 @@ static int mcux_flexcan_start(const struct device *dev)
}
}
/* Clear error counters */
/* Reset statistics and clear error counters */
CAN_STATS_RESET(dev);
config->base->ECR &= ~(CAN_ECR_TXERRCNT_MASK | CAN_ECR_RXERRCNT_MASK);
/* Delay this until start since setting the timing automatically exits freeze mode */

2
drivers/can/can_rcar.c
View file

@ -592,6 +592,8 @@ static int can_rcar_start(const struct device *dev)
k_mutex_lock(&data->inst_mutex, K_FOREVER);
CAN_STATS_RESET(dev);
ret = can_rcar_enter_operation_mode(config);
if (ret != 0) {
LOG_ERR("failed to enter operation mode (err %d)", ret);

2
drivers/can/can_stm32.c
View file

@ -383,6 +383,8 @@ static int can_stm32_start(const struct device *dev)
}
}
CAN_STATS_RESET(dev);
ret = can_stm32_leave_init_mode(can);
if (ret < 0) {
LOG_ERR("Failed to leave init mode");

12
include/zephyr/drivers/can.h
View file

@ -579,6 +579,17 @@ struct can_device_state {
#define CAN_STATS_RX_OVERRUN_INC(dev_) \
STATS_INC(Z_CAN_GET_STATS(dev_), rx_overrun)
/**
* @brief Zero all statistics for a CAN device
*
* The driver is reponsible for resetting the statistics before starting the CAN
* controller.
*
* @param dev_ Pointer to the device structure for the driver instance.
*/
#define CAN_STATS_RESET(dev_) \
stats_reset(&(Z_CAN_GET_STATS(dev_).s_hdr))
/** @cond INTERNAL_HIDDEN */
/**
@ -647,6 +658,7 @@ struct can_device_state {
#define CAN_STATS_FORM_ERROR_INC(dev_)
#define CAN_STATS_ACK_ERROR_INC(dev_)
#define CAN_STATS_RX_OVERRUN_INC(dev_)
#define CAN_STATS_RESET(dev_)
#define CAN_DEVICE_DT_DEFINE(node_id, init_fn, pm, data, config, level, \
prio, api, ...) \