patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

sample: sockets: can: Update error handle flow

Browse source 
This patch updates error handle flows for socket apis.

Fix: #13859
Coverity-CID: 190956

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
This commit is contained in:
Tedd Ho-Jeong An 2019-03-07 11:11:26 -08:00 committed by Anas Nashif
parent fa49e3e4c7
commit 4063b3b149
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
samples/net/sockets/can/src/main.c
View file

@ -110,9 +110,9 @@ static int setup_socket(void)
fd = socket(AF_CAN, SOCK_RAW, CAN_RAW);
if (fd < 0) {
ret = errno;
LOG_ERR("Cannot create CAN socket (%d)", -ret);
return -ret;
ret = -errno;
LOG_ERR("Cannot create CAN socket (%d)", ret);
return ret;
}
can_addr.can_ifindex = net_if_get_by_iface(iface);
@ -121,11 +121,16 @@ static int setup_socket(void)
ret = bind(fd, (struct sockaddr *)&can_addr, sizeof(can_addr));
if (ret < 0) {
ret = -errno;
LOG_ERR("Cannot bind CAN socket (%d)", -ret);
LOG_ERR("Cannot bind CAN socket (%d)", ret);
goto cleanup;
}
setsockopt(fd, SOL_CAN_RAW, CAN_RAW_FILTER, &filter, sizeof(filter));
ret = setsockopt(fd, SOL_CAN_RAW, CAN_RAW_FILTER, &filter, sizeof(filter));
if (ret < 0) {
ret = -errno;
LOG_ERR("Cannot set CAN sockopt (%d)", ret);
goto cleanup;
}
/* Delay TX startup so that RX is ready to receive */
tx_tid = k_thread_create(&tx_data, tx_stack,