patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: config: Initialize semaphore before it's used

Browse source 
Functions like `setup_ipv4` or `setup_ipv6` might already use the
`counter` semaphore, therefore it should be initialized before these
functions are called.

As a result of this issue, the network stack could stall until timeout
under certain circumstances (e.g. when OpenThread was used).

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2019-12-13 11:36:44 +01:00 committed by Jukka Rissanen
parent 41b6b21eeb
commit 43f833800c
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
subsys/net/lib/config/init.c
View file

@ -376,10 +376,6 @@ int net_config_init(const char *app_info, u32_t flags, s32_t timeout)
#endif
}
setup_ipv4(iface);
setup_dhcpv4(iface);
setup_ipv6(iface, flags);
if (flags & NET_CONFIG_NEED_IPV6) {
need++;
}
@ -390,6 +386,10 @@ int net_config_init(const char *app_info, u32_t flags, s32_t timeout)
k_sem_init(&counter, need, UINT_MAX);
setup_ipv4(iface);
setup_dhcpv4(iface);
setup_ipv6(iface, flags);
/* Loop here until we are ready to continue. As we might need
* to wait multiple events, sleep smaller amounts of data.
*/