patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

lib: os: cbprintf_nano: Fix Coverity issue 316025

Browse source 
Coverity does not like that we are passing a pointer to a location
just beyond fixed array. Inside the function access is done through
negative indexes so there was no memory corruption but to satisfy
Coverity pointer to the last element of the array is passed and
we start from index 0 instead of -1.

Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
This commit is contained in:
Krzysztof Chruściński 2023-06-02 12:11:46 +02:00 committed by Anas Nashif
parent 6718869658
commit 44988b95c4
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/os/cbprintf_nano.c
View file

@ -38,7 +38,7 @@ static inline int convert_value(uint_value_type num, unsigned int base,
if (c >= 10) {
c += alpha;
}
buftop[--i] = c + '0';
buftop[i--] = c + '0';
num /= base;
} while (num);
@ -244,7 +244,7 @@ start:
} else {
;
}
data_len = convert_value(d, 10, 0, buf + sizeof(buf));
data_len = convert_value(d, 10, 0, buf + sizeof(buf) - 1);
data = buf + sizeof(buf) - data_len;
break;
}
@ -286,7 +286,7 @@ start:
min_width -= 2;
}
data_len = convert_value(x, 16, ALPHA(*fmt),
buf + sizeof(buf));
buf + sizeof(buf) - 1);
data = buf + sizeof(buf) - data_len;
break;
}