patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

subsys: usb: check for invalid descriptor type request

Browse source 
Implementation of Get Descriptor Request should not return interface
or endpoint descriptors in a single request without configuration
descriptor, see USB Spec. Revision 2.0, 9.4.3 Get Descriptor

This patch fixes linux kernel usbtest subtest 7 and subtest 11 errors.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
This commit is contained in:
Johann Fischer 2018-04-30 16:35:50 +02:00 committed by Anas Nashif
parent 9af44d8256
commit 4b0b65c1b8
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
subsys/usb/usb_device.c
View file

@ -389,6 +389,15 @@ static bool usb_get_descriptor(u16_t type_index, u16_t lang_id,
type = GET_DESC_TYPE(type_index);
index = GET_DESC_INDEX(type_index);
/*
* Invalid types of descriptors,
* see USB Spec. Revision 2.0, 9.4.3 Get Descriptor
*/
if ((type == DESC_INTERFACE) || (type == DESC_ENDPOINT) ||
(type > DESC_OTHER_SPEED)) {
return false;
}
p = (u8_t *)usb_dev.descriptors;
cur_index = 0;