patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: i2c_ll_stm32_v2: reorder to remove duplication

Browse source 
Disabling of Interrupts is duplicated. Move it to a position
that is common to messages that end with and without errors.

Signed-off-by: Daniel Wagenknecht <wagenknecht@clage.de>
This commit is contained in:
Daniel Wagenknecht 2017-10-27 09:50:33 +02:00 committed by Kumar Gala
parent c393bfd8e3
commit 5380bc597f
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/i2c/i2c_ll_stm32_v2.c
View file

@ -142,19 +142,17 @@ int stm32_i2c_msg_write(struct device *dev, struct i2c_msg *msg,
LL_I2C_EnableIT_NACK(i2c);
k_sem_take(&data->device_sync_sem, K_FOREVER);
LL_I2C_DisableIT_TX(i2c);
LL_I2C_DisableIT_NACK(i2c);
if (data->current.is_nack || data->current.is_err) {
goto error;
}
msg_done(dev, msg->flags);
LL_I2C_DisableIT_TX(i2c);
LL_I2C_DisableIT_NACK(i2c);
return 0;
error:
LL_I2C_DisableIT_TX(i2c);
LL_I2C_DisableIT_NACK(i2c);
if (data->current.is_nack) {
SYS_LOG_DBG("%s: NACK", __func__);
data->current.is_nack = 0;
@ -185,16 +183,16 @@ int stm32_i2c_msg_read(struct device *dev, struct i2c_msg *msg,
LL_I2C_EnableIT_RX(i2c);
k_sem_take(&data->device_sync_sem, K_FOREVER);
LL_I2C_DisableIT_RX(i2c);
if (data->current.is_err) {
goto error;
}
msg_done(dev, msg->flags);
LL_I2C_DisableIT_RX(i2c);
return 0;
error:
LL_I2C_DisableIT_RX(i2c);
SYS_LOG_DBG("%s: ERR %d", __func__, data->current.is_err);
data->current.is_err = 0;