patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: pwm: pwm_pca9685 set_pre_scale when not in restart mode

Browse source 
The pca9685 driver assumes the chip will be in "restart" mode
after putting it to sleep. This is not necessarily the case, which
can cause setting the prescaler to fail.
This fix allows the precaler to always be set and only restart the pwm's
when the chip was actually in restart mode after being put to sleep.

Signed-off-by: Jaap Versteegh <j.r.versteegh@gmail.com>
This commit is contained in:
Jaap Versteegh 2023-10-19 17:48:21 +02:00 committed by Carles Cufí
parent ee2e8485e8
commit 54c62232fc
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/pwm/pwm_pca9685.c
View file

@ -119,6 +119,7 @@ static int set_pre_scale(const struct device *dev, uint8_t value)
struct pca9685_data *data = dev->data;
uint8_t mode1;
int ret;
uint8_t restart = RESTART;
k_mutex_lock(&data->mutex, K_FOREVER);
@ -134,9 +135,7 @@ static int set_pre_scale(const struct device *dev, uint8_t value)
}
if ((mode1 & RESTART) == 0x00) {
LOG_ERR("RESTART bit should be set");
ret = -EIO;
goto out;
restart = 0;
}
ret = set_reg(dev, ADDR_PRE_SCALE, value);
@ -152,7 +151,7 @@ static int set_pre_scale(const struct device *dev, uint8_t value)
k_sleep(OSCILLATOR_STABILIZE);
ret = set_reg(dev, ADDR_MODE1, AUTO_INC | RESTART);
ret = set_reg(dev, ADDR_MODE1, AUTO_INC | restart);
if (ret != 0) {
goto out;
}