patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

mgmt/mcumgr/lib: Make version string work with CONFIG_NEWLIB_LIBC

Browse source 
By default the newlib does not compile with %hhu processing,
to avoid turning on additional options for newlib compilation
this commit changes formatting string to use %hu instead.
The commit fixes problem with malformed version string being
returned, by smp_svr, when CONFIG_NEWLIB_LIBC=y is set together
with CONFIG_NEWLIB_LIBC_NANO=y.

Fixes #45261

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This commit is contained in:
Dominik Ermel 2022-05-04 09:57:59 +00:00 committed by Carles Cufí
parent 0c051d0dd6
commit 578cb132ff
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
subsys/mgmt/mcumgr/lib/cmd/img_mgmt/src/img_mgmt_util.c
View file

@ -16,8 +16,9 @@ img_mgmt_ver_str(const struct image_version *ver, char *dst)
int rc = 0;
int rc1 = 0;
rc = snprintf(dst, IMG_MGMT_VER_MAX_STR_LEN, "%hhu.%hhu.%hu",
ver->iv_major, ver->iv_minor, ver->iv_revision);
rc = snprintf(dst, IMG_MGMT_VER_MAX_STR_LEN, "%hu.%hu.%hu",
(uint16_t)ver->iv_major, (uint16_t)ver->iv_minor,
ver->iv_revision);
if (rc >= 0 && ver->iv_build_num != 0) {
rc1 = snprintf(&dst[rc], IMG_MGMT_VER_MAX_STR_LEN - rc, ".%u",