patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

sensor: bq274xx: add an initialization delay

Browse source 
The various BQ27xxx datasheet seems to indicate a typical power-up or
shutdown to communication time of 250ms typical.

Adjust the driver to include:
- a check to ensure that the MCU has been powered for at least 300ms
  before any communicaton
- the same delay when exiting shutdown state

Link: https://www.ti.com/lit/gpn/BQ27427
Suggested-by: Nick Ward <nix.ward@gmail.com>
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
This commit is contained in:
Fabio Baltieri 2023-07-28 22:25:26 +01:00 committed by Carles Cufí
parent 72a2b81f75
commit 5d1a4d4589
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/sensor/bq274xx/bq274xx.c
View file

@ -43,8 +43,10 @@ LOG_MODULE_REGISTER(bq274xx, CONFIG_SENSOR_LOG_LEVEL);
/* Time to set pin in order to exit shutdown mode */
#define PIN_DELAY_TIME K_MSEC(1)
/* Time it takes device to initialize before doing any configuration */
#define INIT_TIME K_MSEC(100)
/* Delay from power up or shutdown exit to chip entering active state, this is
* defined as 250ms typical in the datasheet (Power-up communication delay).
*/
#define POWER_UP_DELAY_MS 300
/* Data memory size */
#define BQ27XXX_DM_SZ 32
@ -624,6 +626,7 @@ static int bq274xx_gauge_init(const struct device *dev)
struct bq274xx_data *data = dev->data;
int ret;
uint16_t id;
int32_t delay_remainder_ms;
if (!device_is_ready(config->i2c.bus)) {
LOG_ERR("I2C bus device not ready");
@ -637,6 +640,12 @@ static int bq274xx_gauge_init(const struct device *dev)
}
#endif
delay_remainder_ms = POWER_UP_DELAY_MS - k_uptime_get_32();
if (delay_remainder_ms > 0) {
LOG_DBG("Power up delay remainder: %dms", delay_remainder_ms);
k_msleep(delay_remainder_ms);
}
ret = bq274xx_get_device_type(dev, &id);
if (ret < 0) {
LOG_ERR("Unable to get device ID");
@ -731,7 +740,7 @@ static int bq274xx_exit_shutdown_mode(const struct device *dev)
}
if (!config->lazy_loading) {
k_sleep(INIT_TIME);
k_sleep(K_MSEC(POWER_UP_DELAY_MS));
ret = bq274xx_gauge_configure(dev);
if (ret < 0) {