patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: spi: ifx_cat1: drop non-existing DT properties

Browse source 
It looks like driver references quite a few non-existing properties in
devicetree (see dts/bindings/spi/infineon,cat1-spi.yml). This mistake
was hidden because of DT_INST_PROP_OR(), which expands to the default if
the property is not present. However, after
260fc89643, the issue became visible
because sme DT_INST_PROP_OR() were changed to DT_INST_PROP().

Note that only fields not initialized to 0 (or false) have been kept.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
This commit is contained in:
Gerard Marull-Paretas 2024-01-30 16:19:00 +01:00 committed by Carles Cufí
parent 017b01659f
commit 5ef7404c7c
1 changed files with 5 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
drivers/spi/spi_ifx_cat1.c
View file

@ -333,24 +333,11 @@ static int ifx_cat1_spi_init(const struct device *dev)
.rxDataWidth = 8, /* overwrite by cfg */ \ .rxDataWidth = 8, /* overwrite by cfg */ \
.txDataWidth = 8, /* overwrite by cfg */ \ .txDataWidth = 8, /* overwrite by cfg */ \
.enableMsbFirst = true, /* overwrite by cfg */ \ .enableMsbFirst = true, /* overwrite by cfg */ \
.subMode = DT_INST_PROP_OR(n, sub_mode, CY_SCB_SPI_MOTOROLA), \ .subMode = CY_SCB_SPI_MOTOROLA, \
.oversample = \ .oversample = IFX_CAT1_SPI_DEFAULT_OVERSAMPLE, \
DT_INST_PROP_OR(n, oversample, IFX_CAT1_SPI_DEFAULT_OVERSAMPLE), \ .enableMisoLateSample = true, \
.enableFreeRunSclk = DT_INST_PROP(n, enable_free_run_sclk), \ .ssPolarity = CY_SCB_SPI_ACTIVE_LOW, \
.enableInputFilter = DT_INST_PROP(n, enable_input_filter), \ }, \
.enableMisoLateSample = \
DT_INST_PROP_OR(n, enable_miso_late_sample, true), \
.enableTransferSeperation = \
DT_INST_PROP(n, enable_transfer_seperation), \
.enableWakeFromSleep = DT_INST_PROP(n, enableWakeFromSleep), \
.ssPolarity = DT_INST_PROP_OR(n, ss_polarity, CY_SCB_SPI_ACTIVE_LOW), \
.rxFifoTriggerLevel = DT_INST_PROP_OR(n, rx_fifo_trigger_level, 0), \
.rxFifoIntEnableMask = DT_INST_PROP_OR(n, rx_fifo_int_enable_mask, 0), \
.txFifoTriggerLevel = DT_INST_PROP_OR(n, tx_fifo_trigger_level, 0), \
.txFifoIntEnableMask = DT_INST_PROP_OR(n, tx_fifo_int_enable_mask, 0), \
.masterSlaveIntEnableMask = \
DT_INST_PROP_OR(n, master_slave_int_enable_mask, 0)}, \
\
.irq_priority = DT_INST_IRQ(n, priority), \ .irq_priority = DT_INST_IRQ(n, priority), \
}; \ }; \
DEVICE_DT_INST_DEFINE(n, &ifx_cat1_spi_init, NULL, &spi_cat1_data_##n, \ DEVICE_DT_INST_DEFINE(n, &ifx_cat1_spi_init, NULL, &spi_cat1_data_##n, \