patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: if: default NET_IF_LOWER_UP at compile time

Browse source 
The `net_if` layer should not be forcing `NET_IF_LOWER_UP` to be set on
all interfaces at runtime. Because `net_init` runs relatively late by
default, this is overriding any control the driver itself may have
performed using `net_if_carrier_on/off`.

Initialise this bit at compile-time instead. As the structure is already
being initialised, this doesn't increase any footprints.

Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
This commit is contained in:
Jordan Yates 2023-06-20 18:05:36 +10:00 committed by Fabio Baltieri
parent c5bb959b25
commit 6271f2fa56
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/zephyr/net/net_if.h
View file

@ -2562,6 +2562,7 @@ struct net_if_api {
.l2 = &(NET_L2_GET_NAME(_l2)), \
.l2_data = &(NET_L2_GET_DATA(dev_id, sfx)), \
.mtu = _mtu, \
.flags = {BIT(NET_IF_LOWER_UP)}, \
}; \
static Z_DECL_ALIGN(struct net_if) \
NET_IF_GET_NAME(dev_id, sfx)[_num_configs] \
@ -2579,6 +2580,7 @@ struct net_if_api {
.dev = &(DEVICE_NAME_GET(dev_id)), \
.mtu = _mtu, \
.l2 = &(NET_L2_GET_NAME(OFFLOADED_NETDEV)), \
.flags = {BIT(NET_IF_LOWER_UP)}, \
}; \
static Z_DECL_ALIGN(struct net_if) \
NET_IF_GET_NAME(dev_id, sfx)[NET_IF_MAX_CONFIGS] \

2
subsys/net/ip/net_if.c
View file

@ -425,8 +425,6 @@ static inline void init_iface(struct net_if *iface)
net_if_flag_set(iface, NET_IF_IPV6);
#endif
net_if_flag_test_and_set(iface, NET_IF_LOWER_UP);
net_virtual_init(iface);
NET_DBG("On iface %p", iface);