patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

sanitycheck: Fail test if the process returns != 0

Browse source 
If the test process returns an error (return code != 0),
it should be considered a failure, even if the handler
considers the test passed.
But this is not done when we are killing (SIGTERM) the processes,
as then the return code is not necessarily sensible.

Without this, for example, when running with valgrind, all valgrind
errors are missed.

Signed-off-by: Alberto Escolar Piedras <alpi@oticon.com>
This commit is contained in:
Alberto Escolar Piedras 2018-12-11 15:13:05 +01:00 committed by Carles Cufí
parent ace7bf9508
commit 661bc8206f
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
scripts/sanitycheck
View file

@ -343,6 +343,7 @@ class BinaryHandler(Handler):
super().__init__(instance)
self.valgrind = False
self.terminated = False
def _output_reader(self, proc, harness):
log_out_fp = open(self.log, "wt")
@ -352,13 +353,18 @@ class BinaryHandler(Handler):
log_out_fp.flush()
harness.handle(line.decode('utf-8').rstrip())
if harness.state:
proc.terminate()
try:
#POSIX arch based ztests end on their own,
#so let's give it up to 100ms to do so
proc.wait(0.1)
except subprocess.TimeoutExpired:
proc.terminate()
self.terminated = True
break
log_out_fp.close()
def handle(self):
out_state = "failed"
harness_name = self.instance.test.harness.capitalize()
harness_import = HarnessImporter(harness_name)
@ -384,13 +390,10 @@ class BinaryHandler(Handler):
t.join(self.timeout)
if t.is_alive():
proc.terminate()
out_state = "timeout"
self.terminated = True
t.join()
proc.wait()
self.returncode = proc.returncode
if proc.returncode != 0:
out_state = "failed"
if options.enable_coverage:
returncode = subprocess.call(["GCOV_PREFIX=" + self.outdir,
@ -401,10 +404,14 @@ class BinaryHandler(Handler):
subprocess.call(["stty", "sane"])
self.instance.results = harness.tests
if harness.state:
if self.terminated==False and self.returncode != 0:
#When a process is killed, the default handler returns 128 + SIGTERM
#so in that case the return code itself is not meaningful
self.set_state("error", {})
elif harness.state:
self.set_state(harness.state, {})
else:
self.set_state(out_state, {})
self.set_state("timeout", {})
class DeviceHandler(Handler):