patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

kernel: Remove duplicate execution_cycles write and improve docstring

Browse source 
There is a duplicate write in `z_sched_thread_usage()` that can be
removed. Also modified the docstrings to `k_thread_runtime_stats` to
help better describe the differences between execution_cycles and
total_cycles when getting stats for the CPU or a thread

Signed-off-by: Eric Johnson <eric@memfault.com>
This commit is contained in:
Eric Johnson 2024-04-11 13:32:03 -05:00 committed by Anas Nashif
parent 83d6cd4710
commit 69c5c6d511
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
include/zephyr/kernel/thread.h
View file

@ -206,13 +206,12 @@ struct _thread_userspace_local_data {
typedef struct k_thread_runtime_stats { typedef struct k_thread_runtime_stats {
#ifdef CONFIG_SCHED_THREAD_USAGE #ifdef CONFIG_SCHED_THREAD_USAGE
uint64_t execution_cycles;
uint64_t total_cycles; /* total # of non-idle cycles */
/* /*
* In the context of thread statistics, [execution_cycles] is the same * For CPU stats, execution_cycles is the sum of non-idle + idle cycles.
* as the total # of non-idle cycles. In the context of CPU statistics, * For thread stats, execution_cycles = total_cycles.
* it refers to the sum of non-idle + idle cycles.
*/ */
uint64_t execution_cycles; /* total # of cycles (cpu: non-idle + idle) */
uint64_t total_cycles; /* total # of non-idle cycles */
#endif /* CONFIG_SCHED_THREAD_USAGE */ #endif /* CONFIG_SCHED_THREAD_USAGE */
#ifdef CONFIG_SCHED_THREAD_USAGE_ANALYSIS #ifdef CONFIG_SCHED_THREAD_USAGE_ANALYSIS

1
kernel/usage.c
View file

@ -220,7 +220,6 @@ void z_sched_thread_usage(struct k_thread *thread,
#ifdef CONFIG_SCHED_THREAD_USAGE_ALL #ifdef CONFIG_SCHED_THREAD_USAGE_ALL
stats->idle_cycles = 0; stats->idle_cycles = 0;
#endif /* CONFIG_SCHED_THREAD_USAGE_ALL */ #endif /* CONFIG_SCHED_THREAD_USAGE_ALL */
stats->execution_cycles = thread->base.usage.total;
k_spin_unlock(&usage_lock, key); k_spin_unlock(&usage_lock, key);
} }