patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: wifi: Replace numeric values with defines

Browse source 
There should be a particular defines which clarify the
use of that number. So, replacing numbers with defines
in wifi shell.

Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
This commit is contained in:
Kapil Bhatt 2024-03-27 16:58:18 +05:30 committed by Fabio Baltieri
parent 717fccaa09
commit 6a0e6e4737
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
include/zephyr/net/wifi_mgmt.h
View file

@ -48,6 +48,13 @@ extern "C" {
#endif /* CONFIG_WIFI_MGMT_SCAN_CHAN_MAX_MANUAL */
#define WIFI_MGMT_BAND_STR_SIZE_MAX 8
#define WIFI_MGMT_SCAN_MIN_DWELL_TIME_ACTIVE 5
#define WIFI_MGMT_SCAN_MAX_DWELL_TIME_ACTIVE 1000
#define WIFI_MGMT_SCAN_MIN_DWELL_TIME_PASSIVE 10
#define WIFI_MGMT_SCAN_MAX_DWELL_TIME_PASSIVE 1000
#define WIFI_MGMT_SCAN_DEFAULT_DWELL_TIME_ACTIVE 50
#define WIFI_MGMT_SCAN_DEFAULT_DWELL_TIME_PASSIVE 130
#define WIFI_MGMT_SCAN_MAX_BSS_CNT 65535
/** Wi-Fi management commands */
enum net_request_wifi_cmd {

13
subsys/net/l2/wifi/wifi_shell.c
View file

@ -683,7 +683,8 @@ static int wifi_scan_args_to_params(const struct shell *sh,
case 'a':
val = atoi(state->optarg);
if ((val < 5) || (val > 1000)) {
if ((val < WIFI_MGMT_SCAN_MIN_DWELL_TIME_ACTIVE) ||
(val > WIFI_MGMT_SCAN_MAX_DWELL_TIME_ACTIVE)) {
PR_ERROR("Invalid dwell_time_active val\n");
return -ENOEXEC;
}
@ -694,7 +695,8 @@ static int wifi_scan_args_to_params(const struct shell *sh,
case 'p':
val = atoi(state->optarg);
if ((val < 10) || (val > 1000)) {
if ((val < WIFI_MGMT_SCAN_MIN_DWELL_TIME_PASSIVE) ||
(val > WIFI_MGMT_SCAN_MAX_DWELL_TIME_PASSIVE)) {
PR_ERROR("Invalid dwell_time_passive val\n");
return -ENOEXEC;
}
@ -715,7 +717,7 @@ static int wifi_scan_args_to_params(const struct shell *sh,
case 'm':
val = atoi(state->optarg);
if ((val < 0) || (val > 65535)) {
if ((val < 0) || (val > WIFI_MGMT_SCAN_MAX_BSS_CNT)) {
PR_ERROR("Invalid max_bss val\n");
return -ENOEXEC;
}
@ -752,7 +754,10 @@ static int wifi_scan_args_to_params(const struct shell *sh,
static int cmd_wifi_scan(const struct shell *sh, size_t argc, char *argv[])
{
struct net_if *iface = net_if_get_first_wifi();
struct wifi_scan_params params = { .dwell_time_active = 50, .dwell_time_passive = 130, };
struct wifi_scan_params params = { .dwell_time_active =
WIFI_MGMT_SCAN_DEFAULT_DWELL_TIME_ACTIVE,
.dwell_time_passive =
WIFI_MGMT_SCAN_DEFAULT_DWELL_TIME_PASSIVE, };
bool do_scan = true;
int opt_num;