patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

shell: kconfig: Fix SEGGER_SYSTEMVIEW/SHELL_BACKEND_RTT build issue

Browse source 
RTT_CONSOLE depends on CONSOLE, but SEGGER_SYSTEMVIEW and
SHELL_BACKEND_RTT select RTT_CONSOLE without also selecting CONSOLE.

This leads to a build failure in drivers/console/rtt_console.c (compiled
if RTT_CONSOLE is enabled) unless CONSOLE is enabled some other way.
Symbols like CONFIG_RTT_RETRY_DELAY_MS won't be defined, because they
depend on CONSOLE.

Came up in https://github.com/zephyrproject-rtos/zephyr/pull/21860. This
fix was verified there.

(Would be nice to get rid of some 'select's in the console subsystem at
some point. This is a quick fix.)

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2020-01-15 18:44:22 +01:00 committed by Carles Cufí
parent 2addfb4696
commit 7024e7ca7b
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
subsys/debug/Kconfig.segger
View file

@ -16,6 +16,7 @@ if USE_SEGGER_RTT
config SEGGER_SYSTEMVIEW
bool "Segger SystemView support"
select CONSOLE
select RTT_CONSOLE
select THREAD_MONITOR
select THREAD_STACK_INFO

1
subsys/shell/Kconfig.backends
View file

@ -115,6 +115,7 @@ endif # SHELL_BACKEND_SERIAL
config SHELL_BACKEND_RTT
bool "Enable RTT backend"
select USE_SEGGER_RTT
select CONSOLE
select RTT_CONSOLE
help
Enable RTT backend.