patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: modem: sara-r4: Sanitize send_socket_data() semaphore handling

Browse source 
Reset of the sem_response semaphore should be done before sending data.
This prevent any potential race conditions between the rx thread and the
thread running send_socket_data().

Signed-off-by: Xavier Chapron <xavier.chapron@stimio.fr>
This commit is contained in:
Xavier Chapron 2020-11-06 15:53:46 +01:00 committed by Anas Nashif
parent 900d48c88b
commit 7129aff701
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/modem/ublox-sara-r4.c
View file

@ -347,14 +347,20 @@ static ssize_t send_socket_data(struct modem_socket *sock,
/* slight pause per spec so that @ prompt is received */ /* slight pause per spec so that @ prompt is received */
k_sleep(MDM_PROMPT_CMD_DELAY); k_sleep(MDM_PROMPT_CMD_DELAY);
/* Reset response semaphore before sending data
* So that we are sure that we won't use a previously pending one
* And we won't miss the one that is going to be freed
*/
k_sem_reset(&mdata.sem_response);
/* Send data directly on modem iface */
mctx.iface.write(&mctx.iface, buf, buf_len); mctx.iface.write(&mctx.iface, buf, buf_len);
if (K_TIMEOUT_EQ(timeout, K_NO_WAIT)) { if (K_TIMEOUT_EQ(timeout, K_NO_WAIT)) {
ret = 0; ret = 0;
goto exit; goto exit;
} }
k_sem_reset(&mdata.sem_response);
ret = k_sem_take(&mdata.sem_response, timeout); ret = k_sem_take(&mdata.sem_response, timeout);
if (ret == 0) { if (ret == 0) {