patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: modem: gsm: If condition should be bool

Browse source 
Compare these variables properly so that the condition in an if
statement will be boolean.

Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>

Update gsm_ppp.c
This commit is contained in:
Yong Cong Sin 2022-08-02 00:09:50 +08:00 committed by Carles Cufí
parent e5fb94e4a0
commit 7685301df6
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/modem/gsm_ppp.c
View file

@ -452,7 +452,7 @@ MODEM_CMD_DEFINE(on_cmd_atcmdinfo_rssi_cesq)
MODEM_CMD_DEFINE(on_cmd_atcmdinfo_rssi_csq)
{
/* Expected response is "+CSQ: <signal_power>,<qual>" */
if (argc) {
if (argc > 0) {
int rssi = atoi(argv[0]);
if (rssi >= 0 && rssi <= 31) {
@ -509,7 +509,7 @@ static const struct setup_cmd setup_cmds[] = {
MODEM_CMD_DEFINE(on_cmd_atcmdinfo_attached)
{
/* Expected response is "+CGATT: 0|1" so simply look for '1' */
if (argc && atoi(argv[0]) == 1) {
if ((argc > 0) && (atoi(argv[0]) == 1)) {
LOG_INF("Attached to packet service!");
}
@ -559,7 +559,7 @@ static int gsm_setup_mccmno(struct gsm_modem *gsm)
{
int ret = 0;
if (CONFIG_MODEM_GSM_MANUAL_MCCMNO[0]) {
if (CONFIG_MODEM_GSM_MANUAL_MCCMNO[0] != '\0') {
/* use manual MCC/MNO entry */
ret = modem_cmd_send_nolock(&gsm->context.iface,
&gsm->context.cmd_handler,
@ -625,13 +625,13 @@ static void set_ppp_carrier_on(struct gsm_modem *gsm)
/* For the first call, we want to call ppp_start()... */
ret = api->start(ppp_dev);
if (ret) {
if (ret < 0) {
LOG_ERR("ppp start returned %d", ret);
}
} else {
/* ...but subsequent calls should be to ppp_enable() */
ret = net_if_l2(iface)->enable(iface, true);
if (ret) {
if (ret < 0) {
LOG_ERR("ppp l2 enable returned %d", ret);
}
}