patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

lorawan: services: clock_sync: fix resync with multiple transmissions

Browse source 
Only the first resync transmission was sent out immediately because
the work item was rescheduled to the usual periodicity in the work
handler immediately after sending out the first transmission.

Signed-off-by: Martin Jäger <martin@libre.solar>
This commit is contained in:
Martin Jäger 2024-02-05 13:59:40 +01:00 committed by Carles Cufí
parent 8bb9bb67db
commit 776c850896
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
subsys/lorawan/services/clock_sync.c
View file

@ -191,11 +191,6 @@ static int clock_sync_app_time_req(void)
lorawan_services_schedule_uplink(LORAWAN_PORT_CLOCK_SYNC, tx_buf, tx_pos, 0);
if (ctx.nb_transmissions > 0) {
ctx.nb_transmissions--;
lorawan_services_reschedule_work(&ctx.resync_work, K_SECONDS(CLOCK_RESYNC_DELAY));
}
return 0;
}
@ -205,10 +200,15 @@ static void clock_sync_resync_handler(struct k_work *work)
clock_sync_app_time_req();
/* Add +-30s jitter to actual periodicity as required */
periodicity = ctx.periodicity - 30 + sys_rand32_get() % 61;
if (ctx.nb_transmissions > 0) {
ctx.nb_transmissions--;
lorawan_services_reschedule_work(&ctx.resync_work, K_SECONDS(CLOCK_RESYNC_DELAY));
} else {
/* Add +-30s jitter to actual periodicity as required */
periodicity = ctx.periodicity - 30 + sys_rand32_get() % 61;
lorawan_services_reschedule_work(&ctx.resync_work, K_SECONDS(periodicity));
lorawan_services_reschedule_work(&ctx.resync_work, K_SECONDS(periodicity));
}
}
int lorawan_clock_sync_get(uint32_t *gps_time)