patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers/spi: Simplify how error is forwarded from ISR handler in DW

Browse source 
No need to test it twice then in completed().

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
This commit is contained in:
Tomasz Bursztyka 2018-03-28 10:45:32 +02:00 committed by Carles Cufí
parent a868561339
commit 79308dd1a8
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/spi/spi_dw.c
View file

@ -50,7 +50,7 @@ static inline bool spi_dw_is_slave(struct spi_dw_data *spi)
spi_context_is_slave(&spi->ctx));
}
static void completed(struct device *dev, u8_t error)
static void completed(struct device *dev, int error)
{
const struct spi_dw_config *info = dev->config->config_info;
struct spi_dw_data *spi = dev->driver_data;
@ -79,7 +79,7 @@ out:
SYS_LOG_DBG("SPI transaction completed %s error",
error ? "with" : "without");
spi_context_complete(&spi->ctx, error ? -EIO : 0);
spi_context_complete(&spi->ctx, error);
}
static void push_data(struct device *dev)
@ -478,7 +478,7 @@ void spi_dw_isr(struct device *dev)
{
const struct spi_dw_config *info = dev->config->config_info;
u32_t int_status;
u8_t error;
int error;
int_status = read_isr(info->regs);
@ -486,7 +486,7 @@ void spi_dw_isr(struct device *dev)
int_status, read_txflr(info->regs), read_rxflr(info->regs));
if (int_status & DW_SPI_ISR_ERRORS_MASK) {
error = 1;
error = -EIO;
goto out;
}