patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

net: ipv6: use static inlines where it makes sense for stubs

Browse source 
If we're disabling certain features and instead providing function stubs,
it doesn't make sense to use macros for those routines that return values
that the user may check unless we want to provide them with vague errors
like:

src/coap-server.c:101:55: error: expected expression before ';' token
  101 |  ret = net_ipv6_mld_join(iface, &mcast_addr.sin6_addr);

When a function we're mocking up returns a value, use a static inline
stub.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@huawei.com>
This commit is contained in:
Bartosz Golaszewski 2022-07-27 11:01:42 +02:00 committed by Carles Cufí
parent 65e1c6fb1e
commit 7cddc5a6a3
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
subsys/net/ip/ipv6.h
View file

@ -205,7 +205,14 @@ static inline int net_ipv6_finalize(struct net_pkt *pkt,
#if defined(CONFIG_NET_IPV6_MLD)
int net_ipv6_mld_join(struct net_if *iface, const struct in6_addr *addr);
#else
#define net_ipv6_mld_join(...)
static inline int
net_ipv6_mld_join(struct net_if *iface, const struct in6_addr *addr)
{
ARG_UNUSED(iface);
ARG_UNUSED(addr);
return -ENOTSUP;
}
#endif /* CONFIG_NET_IPV6_MLD */
/**
@ -219,7 +226,14 @@ int net_ipv6_mld_join(struct net_if *iface, const struct in6_addr *addr);
#if defined(CONFIG_NET_IPV6_MLD)
int net_ipv6_mld_leave(struct net_if *iface, const struct in6_addr *addr);
#else
#define net_ipv6_mld_leave(...)
static inline int
net_ipv6_mld_leave(struct net_if *iface, const struct in6_addr *addr)
{
ARG_UNUSED(iface);
ARG_UNUSED(addr);
return -ENOTSUP;
}
#endif /* CONFIG_NET_IPV6_MLD */
/**