patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

usb: usb_dc_native_posix: Check return code in handle_usb_data()

Browse source 
Fixes coverity complaints dealing with send()

Fixes #20839
Fixes #20841

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
This commit is contained in:
Andrei Emeltchenko 2019-11-21 11:13:26 +02:00 committed by Anas Nashif
parent 1d81c0cf31
commit 80dbcfa306
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/usb/device/usb_dc_native_posix.c
View file

@ -561,6 +561,9 @@ int handle_usb_data(struct usbip_header *hdr)
return -EIO;
}
} else {
u8_t buf_len = usbip_ctrl.in_ep_ctrl[ep_idx].buf_len;
u8_t *buf = usbip_ctrl.in_ep_ctrl[ep_idx].buf;
if (ep_idx >= USBIP_IN_EP_NUM) {
return -EINVAL;
}
@ -570,15 +573,18 @@ int handle_usb_data(struct usbip_header *hdr)
usbip_skip_setup();
LOG_DBG("Send %u bytes", usbip_ctrl.in_ep_ctrl[ep_idx].buf_len);
LOG_DBG("Send %u bytes", buf_len);
/* Send queued data */
usbip_send_common(ep, usbip_ctrl.in_ep_ctrl[ep_idx].buf_len);
usbip_send(ep, usbip_ctrl.in_ep_ctrl[ep_idx].buf,
usbip_ctrl.in_ep_ctrl[ep_idx].buf_len);
if (!usbip_send_common(ep, buf_len)) {
return -EIO;
}
LOG_HEXDUMP_DBG(usbip_ctrl.in_ep_ctrl[ep_idx].buf,
usbip_ctrl.in_ep_ctrl[ep_idx].buf_len, ">");
if (usbip_send(ep, buf, buf_len) != buf_len) {
return -EIO;
}
LOG_HEXDUMP_DBG(buf, buf_len, ">");
/* Indicate data sent */
ep_cb(ep, USB_DC_EP_DATA_IN);