patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

net: shell: ping: Fix double packet unref in ping reply handler

Browse source 
This was somehow missed, but since ICMP rework, message handlers should
not dereference the packet, as it's done by the ICMP lib.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2023-11-30 13:49:50 +01:00 committed by Henrik Brix Andersen
parent 67082289e1
commit 839553a7d9
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subsys/net/lib/shell/ping.c
View file

@ -104,7 +104,6 @@ static int handle_ipv6_echo_reply(struct net_icmp_ctx *ctx,
ping_done(&ping_ctx);
}
net_pkt_unref(pkt);
return 0;
}
#else
@ -179,7 +178,6 @@ static int handle_ipv4_echo_reply(struct net_icmp_ctx *ctx,
ping_done(&ping_ctx);
}
net_pkt_unref(pkt);
return 0;
}
#else