patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: led: lp50xx: brightness: don't check uint >= 0

Browse source 
No need to check if an uint8_t is greater or equal 0 in
lp50xx_set_brightness.
Fixes CID 322654

Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
This commit is contained in:
Thomas Stranger 2024-02-07 20:35:01 +01:00 committed by Henrik Brix Andersen
parent a0a2e9536b
commit 850382bfd2
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/led/lp50xx.c
View file

@ -23,7 +23,6 @@
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(lp50xx, CONFIG_LED_LOG_LEVEL);
#define LP50XX_MIN_BRIGHTNESS 0U
#define LP50XX_MAX_BRIGHTNESS 100U
/*
@ -127,13 +126,9 @@ static int lp50xx_set_brightness(const struct device *dev,
return -ENODEV;
}
if (!IN_RANGE(value, LP50XX_MIN_BRIGHTNESS, LP50XX_MAX_BRIGHTNESS)) {
LOG_ERR("%s: brightness value out of bounds: "
"val=%d, min=%d, max=%d",
dev->name,
value,
LP50XX_MIN_BRIGHTNESS,
LP50XX_MAX_BRIGHTNESS);
if (value > LP50XX_MAX_BRIGHTNESS) {
LOG_ERR("%s: brightness value out of bounds: val=%d, max=%d",
dev->name, value, LP50XX_MAX_BRIGHTNESS);
return -EINVAL;
}