patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: mdns_responder: Avoid joining IPv4 mcast group if iface is down

Browse source 
Check if the interface is down before joining IPv4 mDNS multicast
group. This avoids warning later when the network packet cannot be sent.

Fixes #71121

Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
This commit is contained in:
Jukka Rissanen 2024-04-06 19:25:59 +03:00 committed by Carles Cufí
parent a8fa742b18
commit 85911bcfc1
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
subsys/net/lib/dns/mdns_responder.c
View file

@ -99,8 +99,8 @@ static void mdns_iface_event_handler(struct net_mgmt_event_callback *cb,
int ret = net_ipv4_igmp_join(iface, &local_addr4.sin_addr, NULL);
if (ret < 0) {
NET_DBG("Cannot add IPv4 multicast address to iface %p",
iface);
NET_DBG("Cannot add IPv4 multicast address to iface %d",
net_if_get_by_iface(iface));
}
#endif /* defined(CONFIG_NET_IPV4) */
}
@ -653,10 +653,25 @@ static void iface_ipv4_cb(struct net_if *iface, void *user_data)
struct in_addr *addr = user_data;
int ret;
if (!net_if_is_up(iface)) {
struct net_if_mcast_addr *maddr;
NET_DBG("Interface %d is down, not joining mcast group yet",
net_if_get_by_iface(iface));
maddr = net_if_ipv4_maddr_add(iface, addr);
if (!maddr) {
NET_DBG("Cannot add multicast address %s",
net_sprint_ipv4_addr(addr));
}
return;
}
ret = net_ipv4_igmp_join(iface, addr, NULL);
if (ret < 0) {
NET_DBG("Cannot add IPv4 multicast address to iface %p",
iface);
NET_DBG("Cannot add IPv4 multicast address to iface %d",
net_if_get_by_iface(iface));
}
}