patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: uart: esp32: fix poll in return value

Browse source 
ESP32 uart_poll_in should return 0 on success and not
the total amount of data read.

This also adds a check in fifo_fill call to
avoid negative values, otherwise it would send garbage
to uart

Closes #41352

Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
This commit is contained in:
Sylvio Alves 2021-12-23 17:45:14 -03:00 committed by Christopher Friedt
parent 397101d322
commit 92fb477641
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/serial/uart_esp32.c
View file

@ -103,7 +103,8 @@ static int uart_esp32_poll_in(const struct device *dev, unsigned char *p_char)
}
uart_hal_read_rxfifo(&DEV_CFG(dev)->hal, p_char, &inout_rd_len);
return inout_rd_len;
return 0;
}
static void uart_esp32_poll_out(const struct device *dev, unsigned char c)
@ -355,6 +356,10 @@ static int uart_esp32_fifo_fill(const struct device *dev,
{
uint32_t written = 0;
if (len < 0) {
return 0;
}
uart_hal_write_txfifo(&DEV_CFG(dev)->hal, tx_data, len, &written);
return written;
}