patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

sensor: max17055: add missing return value check

Browse source 
This commit adds a missing return value check during register read.
Added an imidiate return to remove the seemingly unwanted side
effect of also waiting for the bus read to work.

Fixes #65383

Signed-off-by: Benjamin Björnsson <benjamin.bjornsson@gmail.com>
This commit is contained in:
Benjamin Björnsson 2023-11-17 18:47:08 +01:00 committed by Henrik Brix Andersen
parent 83ada28178
commit 9781d13f19
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/sensor/max17055/max17055.c
View file

@ -427,6 +427,7 @@ static int max17055_gauge_init(const struct device *dev)
{
int16_t tmp;
const struct max17055_config *const config = dev->config;
int ret;
if (!device_is_ready(config->i2c.bus)) {
LOG_ERR("Bus device is not ready");
@ -445,7 +446,10 @@ static int max17055_gauge_init(const struct device *dev)
/* Wait for FSTAT_DNR to be cleared */
tmp = FSTAT_DNR;
while (tmp & FSTAT_DNR) {
max17055_reg_read(dev, FSTAT, &tmp);
ret = max17055_reg_read(dev, FSTAT, &tmp);
if (ret) {
return ret;
}
}
if (max17055_init_config(dev)) {