patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

tests: lib: c_lib: fix double promotion error

Browse source 
Fix double promotion warnings

Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
This commit is contained in:
Ryan McClelland 2023-12-10 12:32:26 -08:00 committed by Fabio Baltieri
parent 987eb10faf
commit 9804c60a4e
1 changed files with 22 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
tests/lib/c_lib/common/src/test_sqrt.c
View file

@ -16,16 +16,8 @@
#define NAN (__builtin_nansf(""))
#endif
#ifndef NANF
#define NANF (__builtin_nans(""))
#endif
#ifndef INF
#define INF (__builtin_inf())
#endif
#ifndef INFF
#define INFF (__builtin_inff())
#ifndef INFINITY
#define INFINITY (__builtin_inff())
#endif
static float test_floats[] = {
@ -91,14 +83,13 @@ static int isnanf(float x)
#endif
/* small errors are expected, computed as percentage error */
#define MAX_FLOAT_ERROR_PERCENT (3.5e-5)
#define MAX_FLOAT_ERROR_PERCENT (3.5e-5f)
#define MAX_DOUBLE_ERROR_PERCENT (4.5e-14)
ZTEST(libc_common, test_sqrtf)
{
int i;
float exponent, resf, square, root_squared;
double error;
float exponent, resf, square, root_squared, error;
uint32_t max_error;
int32_t ierror;
int32_t *p_square = (int32_t *)&square;
@ -107,16 +98,16 @@ int32_t *p_root_squared = (int32_t *)&root_squared;
max_error = 0;
/* test the special cases of 0.0, NAN, -NAN, INF, -INF, and -10.0 */
/* test the special cases of 0.0, NAN, -NAN, INFINITY, -INFINITY, and -10.0 */
zassert_true(sqrtf(0.0f) == 0.0f, "sqrtf(0.0)");
zassert_true(isnanf(sqrtf(NANF)), "sqrt(nan)");
zassert_true(isnanf(sqrtf(NAN)), "sqrt(nan)");
#ifdef issignallingf
zassert_true(issignallingf(sqrtf(NANF)), "ssignalingf(sqrtf(nan))");
zassert_true(issignallingf(sqrtf(NAN)), "ssignalingf(sqrtf(nan))");
/* printf("issignallingf();\n"); */
#endif
zassert_true(isnanf(sqrtf(-NANF)), "isnanf(sqrtf(-nan))");
zassert_true(isinff(sqrtf(INFF)), "isinff(sqrt(inf))");
zassert_true(isnanf(sqrtf(-INFF)), "isnanf(sqrt(-inf))");
zassert_true(isnanf(sqrtf(-NAN)), "isnanf(sqrtf(-nan))");
zassert_true(isinff(sqrtf(INFINITY)), "isinff(sqrt(inf))");
zassert_true(isnanf(sqrtf(-INFINITY)), "isnanf(sqrt(-inf))");
zassert_true(isnanf(sqrtf(-10.0f)), "isnanf(sqrt(-10.0))");
for (exponent = 1.0e-10f; exponent < 1.0e10f; exponent *= 10.0f) {
@ -124,12 +115,12 @@ int32_t *p_root_squared = (int32_t *)&root_squared;
square = test_floats[i] * exponent;
resf = sqrtf(square);
root_squared = resf * resf;
zassert_true((resf > 0.0f) && (resf < INFF),
zassert_true((resf > 0.0f) && (resf < INFINITY),
"sqrtf out of range");
if ((resf > 0.0f) && (resf < INFF)) {
if ((resf > 0.0f) && (resf < INFINITY)) {
error = (square - root_squared) /
square * 100;
if (error < 0.0) {
if (error < 0.0f) {
error = -error;
}
/* square and root_squared should be almost identical
@ -143,7 +134,7 @@ int32_t *p_root_squared = (int32_t *)&root_squared;
}
} else {
/* negative, +NaN, -NaN, inf or -inf */
error = 0.0;
error = 0.0f;
}
zassert_true(error < MAX_FLOAT_ERROR_PERCENT,
"max sqrtf error exceeded");
@ -166,16 +157,16 @@ int64_t *p_root_squared = (int64_t *)&root_squared;
max_error = 0;
/* test the special cases of 0.0, NAN, -NAN, INF, -INF, and -10.0 */
/* test the special cases of 0.0, NAN, -NAN, INFINITY, -INFINITY, and -10.0 */
zassert_true(sqrt(0.0) == 0.0, "sqrt(0.0)");
zassert_true(isnan(sqrt(NAN)), "sqrt(nan)");
zassert_true(isnan(sqrt((double)NAN)), "sqrt(nan)");
#ifdef issignalling
zassert_true(issignalling(sqrt(NAN)), "ssignaling(sqrt(nan))");
zassert_true(issignalling(sqrt((double)NAN)), "ssignaling(sqrt(nan))");
/* printf("issignalling();\n"); */
#endif
zassert_true(isnan(sqrt(-NAN)), "isnan(sqrt(-nan))");
zassert_true(isinf(sqrt(INF)), "isinf(sqrt(inf))");
zassert_true(isnan(sqrt(-INF)), "isnan(sqrt(-inf))");
zassert_true(isnan(sqrt((double)-NAN)), "isnan(sqrt(-nan))");
zassert_true(isinf(sqrt((double)INFINITY)), "isinf(sqrt(inf))");
zassert_true(isnan(sqrt((double)-INFINITY)), "isnan(sqrt(-inf))");
zassert_true(isnan(sqrt(-10.0)), "isnan(sqrt(-10.0))");
for (exponent = 1.0e-10; exponent < 1.0e10; exponent *= 10.0) {
@ -183,9 +174,9 @@ int64_t *p_root_squared = (int64_t *)&root_squared;
square = test_doubles[i] * exponent;
resd = sqrt(square);
root_squared = resd * resd;
zassert_true((resd > 0.0) && (resd < INF),
zassert_true((resd > 0.0) && (resd < (double)INFINITY),
"sqrt out of range");
if ((resd > 0.0) && (resd < INF)) {
if ((resd > 0.0) && (resd < (double)INFINITY)) {
error = (square - root_squared) /
square * 100;
if (error < 0.0) {