patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

soc: npcx7: add comments for macro funcs used for device tree files.

Browse source 
This CL adds more comments for each macro functions used for device tree
file for better explanations. It also changes all hex values in soc.c to
lower case.

Signed-off-by: Mulin Chao <MLChao@nuvoton.com>
This commit is contained in:
Mulin Chao 2020-09-15 17:21:45 +08:00 committed by Carles Cufí
parent e42a3a5a96
commit 99c208f36a
7 changed files with 274 additions and 77 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/espi/espi_npcx.c
View file

@ -808,7 +808,7 @@ static const struct npcx_alt espi_alts[] = DT_NPCX_ALT_ITEMS_LIST(0);
static const struct espi_npcx_config espi_npcx_config = {
.base = DT_INST_REG_ADDR(0),
.espi_rst_wui = DT_NPCX_ESPI_WUI_ITEM(espi_rst_wui),
.espi_rst_wui = DT_NPCX_WUI_ITEM_BY_NAME(0, espi_rst_wui),
.clk_cfg = DT_NPCX_CLK_CFG_ITEM(0),
.alts_size = ARRAY_SIZE(espi_alts),
.alts_list = espi_alts,

2
drivers/espi/host_subs_npcx.c
View file

@ -157,7 +157,7 @@ struct host_sub_npcx_config host_sub_cfg = {
.inst_kbc = (struct kbc_reg *)DT_INST_REG_ADDR_BY_NAME(0, kbc),
.inst_pm_acpi = (struct pmch_reg *)DT_INST_REG_ADDR_BY_NAME(0, pm_acpi),
.inst_pm_hcmd = (struct pmch_reg *)DT_INST_REG_ADDR_BY_NAME(0, pm_hcmd),
.host_acc_wui = DT_NPCX_ESPI_WUI_ITEM(host_acc_wui),
.host_acc_wui = DT_NPCX_WUI_ITEM_BY_NAME(0, host_acc_wui),
.clks_size = ARRAY_SIZE(host_dev_clk_cfg),
.clks_list = host_dev_clk_cfg,
};

7
drivers/serial/uart_npcx.c
View file

@ -23,7 +23,7 @@ struct uart_npcx_config {
/* clock configuration */
struct npcx_clk_cfg clk_cfg;
/* int-mux configuration */
const struct npcx_wui wui_map;
const struct npcx_wui uart_rx_wui;
/* pinmux configuration */
const uint8_t alts_size;
const struct npcx_alt *alts_list;
@ -343,11 +343,11 @@ static int uart_npcx_init(const struct device *dev)
* Configure the UART wake-up event triggered from a falling edge
* on CR_SIN pin. No need for callback function.
*/
soc_miwu_interrupt_configure(&config->wui_map,
soc_miwu_interrupt_configure(&config->uart_rx_wui,
NPCX_MIWU_MODE_EDGE, NPCX_MIWU_TRIG_LOW);
/* Enable irq of interrupt-input module */
soc_miwu_irq_enable(&config->wui_map);
soc_miwu_irq_enable(&config->uart_rx_wui);
#endif
@ -390,6 +390,7 @@ static int uart_npcx_init(const struct device *dev)
NPCX_UART_IRQ_CONFIG_FUNC_INIT(inst) \
}, \
.clk_cfg = DT_NPCX_CLK_CFG_ITEM(inst), \
.uart_rx_wui = DT_NPCX_WUI_ITEM_BY_NAME(0, uart_rx), \
.alts_size = ARRAY_SIZE(uart_alts##inst), \
.alts_list = uart_alts##inst, \
}; \

4
dts/arm/nuvoton/npcx7m6fb.dtsi
View file

@ -75,7 +75,7 @@
interrupts = <33 0>;
clocks = <&pcc NPCX_CLOCK_BUS_APB2 NPCX_PWDWN_CTL1 4>;
pinctrl = <&alta_uart1_sl1>; /* PIN10.11 */
wui_map = <&wui_cr_sin1>;
uart_rx = <&wui_cr_sin1>;
status = "disabled";
label = "UART_1";
};
@ -86,7 +86,7 @@
interrupts = <32 0>;
clocks = <&pcc NPCX_CLOCK_BUS_APB2 NPCX_PWDWN_CTL7 6>;
pinctrl = <&alta_uart2_sl>; /* PIN75.86 */
wui_map = <&wui_cr_sin2>;
uart_rx = <&wui_cr_sin2>;
status = "disabled";
label = "UART_2";
};

8
dts/bindings/serial/nuvoton,npcx-uart.yaml
View file

@ -16,14 +16,14 @@ properties:
type: phandles
required: true
description: configurations of pinmux controllers
wui_map:
uart_rx:
type: phandle
required: true
description: mapping item between wui and source device
description: mapping item between wui and uart rx START signal
description: |
Mapping table between Wake-Up Input (WUI) and its source device.
Mapping table between Wake-Up Input (WUI) and uart rx START signal.
For example the WUI mapping on NPCX7 UART1 would be
wui_map = <&wui_cr_sin1>;
uart_rx = <&wui_cr_sin1>;
required: true

294
soc/arm/nuvoton_npcx/common/soc_dt.h
View file

@ -7,9 +7,23 @@
#ifndef _NUVOTON_NPCX_SOC_DT_H_
#define _NUVOTON_NPCX_SOC_DT_H_
/*
* Construct a npcx_clk_cfg item from clocks prop which type is 'phandle-array'
* to handle "clock-cells" in current driver device
/**
* @brief Construct a npcx_clk_cfg item from first item in 'clocks' prop which
* type is 'phandle-array' to handle "clock-cells" in current driver.
*
* Example devicetree fragment:
* / {
* uart1: serial@400c4000 {
* clocks = <&pcc NPCX_CLOCK_BUS_APB2 NPCX_PWDWN_CTL1 4>;
* ...
* };
* };
*
* Example usage: *
* const struct npcx_clk_cfg clk_cfg = DT_NPCX_CLK_CFG_ITEM(inst);
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return npcx_clk_cfg item.
*/
#define DT_NPCX_CLK_CFG_ITEM(inst) \
{ \
@ -18,7 +32,13 @@
.bit = DT_PHA(DT_DRV_INST(inst), clocks, bit), \
}
/* Construct a npcx_clk_cfg structure from clocks property at index 'i' */
/**
* @brief Construct a npcx_clk_cfg structure from 'clocks' property at index 'i'
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param i index of clocks prop which type is 'phandle-array'
* @return npcx_clk_cfg item from 'clocks' property at index 'i'
*/
#define DT_NPCX_CLK_CFG_ITEM_BY_IDX(inst, i) \
{ \
.bus = DT_CLOCKS_CELL_BY_IDX(DT_DRV_INST(inst), i, bus), \
@ -26,24 +46,68 @@
.bit = DT_CLOCKS_CELL_BY_IDX(DT_DRV_INST(inst), i, bit), \
},
/* Length of npcx_clk_cfg structures in clocks property */
/**
* @brief Length of 'clocks' property which type is 'phandle-array'
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return length of 'clocks' property which type is 'phandle-array'
*/
#define DT_NPCX_CLK_CFG_ITEMS_LEN(inst) DT_INST_PROP_LEN(inst, clocks)
/* Macro function to construct a list of npcx_clk_cfg items by UTIL_LISTIFY */
#define DT_NPCX_CLK_CFG_ITEMS_FUC(idx, inst) \
DT_NPCX_CLK_CFG_ITEM_BY_IDX(inst, idx)
/**
* @brief Macro function to construct npcx_clk_cfg item in UTIL_LISTIFY
* extension.
*
* @param child child index in UTIL_LISTIFY extension.
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return macro function to construct a npcx_clk_cfg structure.
*/
#define DT_NPCX_CLK_CFG_ITEMS_FUC(child, inst) \
DT_NPCX_CLK_CFG_ITEM_BY_IDX(inst, child)
/**
* @brief Macro function to construct a list of npcx_clk_cfg items by
* UTIL_LISTIFY func
*
* Example devicetree fragment:
* / {
* host_sub: lpc@400c1000 {
* clocks = <&pcc NPCX_CLOCK_BUS_APB3 NPCX_PWDWN_CTL5 3>,
* <&pcc NPCX_CLOCK_BUS_APB3 NPCX_PWDWN_CTL5 4>,
* <&pcc NPCX_CLOCK_BUS_APB3 NPCX_PWDWN_CTL5 5>,
* <&pcc NPCX_CLOCK_BUS_APB3 NPCX_PWDWN_CTL5 6>,
* <&pcc NPCX_CLOCK_BUS_APB3 NPCX_PWDWN_CTL5 7>;
* ...
* };
* Example usage: *
* const struct npcx_clk_cfg clk_cfg[] = DT_NPCX_CLK_CFG_ITEMS_LIST(0);
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return an array of npcx_clk_cfg items.
*/
#define DT_NPCX_CLK_CFG_ITEMS_LIST(inst) { \
UTIL_LISTIFY(DT_NPCX_CLK_CFG_ITEMS_LEN(inst), \
DT_NPCX_CLK_CFG_ITEMS_FUC, \
inst) \
}
/* Get phandle from "pinctrl" prop which type is 'phandles' at index 'i' */
/**
* @brief Get phandle from 'pinctrl' prop which type is 'phandles' at index 'i'
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param i index of pinctrl prop which type is 'phandles'
* @return phandle from 'pinctrl' prop at index 'i'
*/
#define DT_PHANDLE_FROM_PINCTRL(inst, i) \
DT_INST_PHANDLE_BY_IDX(inst, pinctrl, i)
/* Construct a npcx_alt structure from pinctrl property at index 'i' */
/**
* @brief Construct a npcx_alt structure from 'pinctrl' property at index 'i'
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param i index of pinctrl prop which type is 'phandles'
* @return npcx_alt item from 'pinctrl' property at index 'i'
*/
#define DT_NPCX_ALT_ITEM_BY_IDX(inst, i) \
{ \
.group = DT_PHA(DT_PHANDLE_FROM_PINCTRL(inst, i), alts, group), \
@ -51,36 +115,98 @@
.inverted = DT_PHA(DT_PHANDLE_FROM_PINCTRL(inst, i), alts, inv), \
},
/* Length of npcx_alt structures in pinctrl property */
/**
* @brief Length of npcx_alt structures in 'pinctrl' property
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return length of 'pinctrl' property which type is 'phandles'
*/
#define DT_NPCX_ALT_ITEMS_LEN(inst) DT_INST_PROP_LEN(inst, pinctrl)
/* Macro function to construct a list of npcx_alt items by UTIL_LISTIFY */
#define DT_NPCX_ALT_ITEMS_FUC(idx, inst) DT_NPCX_ALT_ITEM_BY_IDX(inst, idx)
/**
* @brief Macro function to construct npcx_alt item in UTIL_LISTIFY extension.
*
* @param child child index in UTIL_LISTIFY extension.
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return macro function to construct a npcx_alt structure.
*/
#define DT_NPCX_ALT_ITEMS_FUC(child, inst) DT_NPCX_ALT_ITEM_BY_IDX(inst, child)
/**
* @brief Macro function to construct a list of npcx_alt items by UTIL_LISTIFY
* func
*
* Example devicetree fragment:
* / {
* uart1: serial@400c4000 {
* pinctrl = <&alta_uart1_sl1>;
* ...
* };
*
* host_sub: lpc@400c1000 {
* pinctrl = <&altb_rxd_sl &altb_txd_sl
* &altb_rts_sl &altb_cts_sl
* &altb_ri_sl &altb_dtr_bout_sl
* &altb_dcd_sl &altb_dsr_sl>;
* ...
* };
* };
*
* Example usage: *
* const struct npcx_alt uart_alts[] = DT_NPCX_ALT_ITEMS_LIST(inst);
* const struct npcx_alt host_uart_alts[] = DT_NPCX_ALT_ITEMS_LIST(inst);
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return an array of npcx_alt items.
*/
#define DT_NPCX_ALT_ITEMS_LIST(inst) { \
UTIL_LISTIFY(DT_NPCX_ALT_ITEMS_LEN(inst), \
DT_NPCX_ALT_ITEMS_FUC, \
inst) \
}
/* Get phandle from "wui_map" prop */
#define DT_PHANDLE_FROM_WUI_MAP(inst) \
DT_INST_PHANDLE(inst, wui_map)
/**
* @brief Get phandle from "name" property which contains wui information.
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param name property 'name' which type is 'phandle' and contains wui info.
* @return phandle from 'name' property.
*/
#define DT_PHANDLE_FROM_WUI_NAME(inst, name) \
DT_INST_PHANDLE(inst, name)
/* Construct a npcx_wui structure from wui_map property */
#define DT_NPCX_WUI_ITEM(inst) \
/**
* @brief Construct a npcx_wui structure from 'name' property
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param name property 'name'which type is 'phandle' and contains wui info.
* @return npcx_wui item from 'name' property.
*/
#define DT_NPCX_WUI_ITEM_BY_NAME(inst, name) \
{ \
.table = DT_PROP(DT_PHANDLE(DT_PHANDLE_FROM_WUI_MAP(inst), \
.table = DT_PROP(DT_PHANDLE(DT_PHANDLE_FROM_WUI_NAME(inst, name), \
miwus), index), \
.group = DT_PHA(DT_PHANDLE_FROM_WUI_MAP(inst), miwus, group), \
.bit = DT_PHA(DT_PHANDLE_FROM_WUI_MAP(inst), miwus, bit), \
},
.group = DT_PHA(DT_PHANDLE_FROM_WUI_NAME(inst, name), miwus, group), \
.bit = DT_PHA(DT_PHANDLE_FROM_WUI_NAME(inst, name), miwus, bit), \
}
/* Get phandle from "wui_maps" prop which type is 'phandles' at index 'i' */
/**
* @brief Get phandle from 'wui_maps' prop which type is 'phandles' at index 'i'
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param i index of 'wui_maps' prop which type is 'phandles'
* @return phandle from 'wui_maps' prop at index 'i'
*/
#define DT_PHANDLE_FROM_WUI_MAPS(inst, i) \
DT_INST_PHANDLE_BY_IDX(inst, wui_maps, i)
/* Construct a npcx_wui structure from wui_maps property at index 'i' */
/**
* @brief Construct a npcx_wui structure from wui_maps property at index 'i'
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @param i index of 'wui_maps' prop which type is 'phandles'
* @return npcx_wui item at index 'i'
*/
#define DT_NPCX_WUI_ITEM_BY_IDX(inst, i) \
{ \
.table = DT_PROP(DT_PHANDLE(DT_PHANDLE_FROM_WUI_MAPS(inst, i), \
@ -89,27 +215,80 @@
.bit = DT_PHA(DT_PHANDLE_FROM_WUI_MAPS(inst, i), miwus, bit), \
},
/* Length of npcx_wui structures in pinctrl property */
/**
* @brief Length of npcx_wui structures in 'wui_maps' property
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return length of 'wui_maps' prop which type is 'phandles'
*/
#define DT_NPCX_WUI_ITEMS_LEN(inst) DT_INST_PROP_LEN(inst, wui_maps)
/* Macro function to construct a list of npcx_wui items by UTIL_LISTIFY */
#define DT_NPCX_WUI_ITEMS_FUC(idx, inst) DT_NPCX_WUI_ITEM_BY_IDX(inst, idx)
/**
* @brief Macro function to construct a list of npcx_wui items by UTIL_LISTIFY
*
* @param child child index in UTIL_LISTIFY extension.
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return macro function to construct a npcx_wui structure.
*/
#define DT_NPCX_WUI_ITEMS_FUC(child, inst) DT_NPCX_WUI_ITEM_BY_IDX(inst, child)
/**
* @brief Macro function to construct a list of npcx_wui items by UTIL_LISTIFY
* func.
*
* Example devicetree fragment:
* / {
* uart1: serial@400c4000 {
* uart_rx = <&wui_cr_sin1>;
* ...
* };
*
* gpio0: gpio@40081000 {
* wui_maps = <&wui_io00 &wui_io01 &wui_io02 &wui_io03
* &wui_io04 &wui_io05 &wui_io06 &wui_io07>;
* ...
* };
* };
*
* Example usage: *
* const struct npcx_wui wui_map = DT_PHANDLE_FROM_WUI_NAME(inst, uart_rx);
* const struct npcx_wui wui_maps[] = DT_NPCX_WUI_ITEMS_LIST(inst);
*
* @param inst instance number for compatible defined in DT_DRV_COMPAT.
* @return an array of npcx_wui items.
*/
#define DT_NPCX_WUI_ITEMS_LIST(inst) { \
UTIL_LISTIFY(DT_NPCX_WUI_ITEMS_LEN(inst), \
DT_NPCX_WUI_ITEMS_FUC, \
inst) \
}
/* Get a node from path '/npcx_miwus_map/map_miwu(0/1/2)_groups' */
/**
* @brief Get a node from path '/npcx_miwus_map/map_miwu(0/1/2)_groups'
*
* @param i index of npcx miwu devices
* @return node identifier with that path.
*/
#define DT_NODE_FROM_MIWU_MAP(i) DT_PATH(npcx7_miwus_int_map, \
map_miwu##i##_groups)
/* Get the index prop from parent MIWU device node */
/**
* @brief Get the index prop from parent MIWU device node.
*
* @param child index in UTIL_LISTIFY extension.
* @return 'index' prop value of the node which compatible type is
* "nuvoton,npcx-miwu".
*/
#define DT_MIWU_IRQ_TABLE_IDX(child) \
DT_PROP(DT_PHANDLE(DT_PARENT(child), parent), index)
/* Functiosn for DT_FOREACH_CHILD to generate a IRQ_CONNECT implementation */
/**
* @brief Macro function for DT_FOREACH_CHILD to generate a IRQ_CONNECT
* implementation.
*
* @param child index in UTIL_LISTIFY extension.
* @return implementation to initialize interrupts of MIWU groups and enable
* them.
*/
#define DT_MIWU_IRQ_CONNECT_IMPL_CHILD_FUNC(child) \
{ \
IRQ_CONNECT(DT_PROP(child, irq), \
@ -120,13 +299,29 @@
irq_enable(DT_PROP(child, irq)); \
}
/* Get a child node from path '/npcx7_espi_vws_map/name' */
/**
* @brief Get a child node from path '/npcx7_espi_vws_map/name'.
*
* @param name a path which name is /npcx7_espi_vws_map/'name'.
* @return child node identifier with that path.
*/
#define DT_NODE_FROM_VWTABLE(name) DT_CHILD(DT_PATH(npcx7_espi_vws_map), name)
/* Get a handle from wui_map property of child node */
/**
* @brief Get phandle from wui_map property of child node with that path.
*
* @param name path which name is /npcx7_espi_vws_map/'name'.
* @return phandle from "wui_map" prop of child node with that path.
*/
#define DT_PHANDLE_VW_WUI(name) DT_PHANDLE(DT_NODE_FROM_VWTABLE(name), wui_map)
/* Construct a npcx_wui structure from wui_map property of vw table by name */
/**
* @brief Construct a npcx_wui structure from wui_map property of a child node
* with that path.
*
* @param name a path which name is /npcx7_espi_vws_map/'name'.
* @return npcx_wui item with that path.
*/
#define DT_NPCX_VW_WUI_ITEM(name) \
{ \
.table = DT_PROP(DT_PHANDLE(DT_PHANDLE_VW_WUI(name), miwus), index),\
@ -134,7 +329,14 @@
.bit = DT_PHA(DT_PHANDLE_VW_WUI(name), miwus, bit), \
}
/* Construct a npcx espi device configuration for vw input signal by name */
/**
* @brief Construct a npcx espi device configuration of vw input signal from
* a child node with that path.
*
* @signal vw input signal name.
* @param name a path which name is /npcx7_espi_vws_map/'name'.
* @return npcx_vw_in_config item with that path.
*/
#define DT_NPCX_VW_IN_CONF(signal, name) \
{ \
.sig = signal, \
@ -143,7 +345,14 @@
.vw_wui = DT_NPCX_VW_WUI_ITEM(name), \
}
/* Construct a npcx espi device configuration for vw output signal by name */
/**
* @brief Construct a npcx espi device configuration of vw output signal from
* a child node with that path.
*
* @signal vw output signal name.
* @param name a path which name is /npcx7_espi_vws_map/'name'.
* @return npcx_vw_in_config item with that path.
*/
#define DT_NPCX_VW_OUT_CONF(signal, name) \
{ \
.sig = signal, \
@ -151,17 +360,4 @@
.bitmask = DT_PROP_BY_IDX(DT_NODE_FROM_VWTABLE(name), vw_reg, 1), \
}
/* Get phandle from "name" prop */
#define DT_PHANDLE_FROM_WUI_NAME(name) \
DT_INST_PHANDLE(0, name)
/* Construct a npcx_wui structure from wui_map property */
#define DT_NPCX_ESPI_WUI_ITEM(name) \
{ \
.table = DT_PROP(DT_PHANDLE(DT_PHANDLE_FROM_WUI_NAME(name), \
miwus), index), \
.group = DT_PHA(DT_PHANDLE_FROM_WUI_NAME(name), miwus, group), \
.bit = DT_PHA(DT_PHANDLE_FROM_WUI_NAME(name), miwus, bit), \
}
#endif /* _NUVOTON_NPCX_SOC_DT_H_ */

34
soc/arm/nuvoton_npcx/npcx7/soc.c
View file

@ -35,11 +35,11 @@ NPCX_REG_OFFSET_CHECK(pmc_reg, PWDWN_CTL7, 0x024);
NPCX_REG_SIZE_CHECK(scfg_reg, 0x02F);
NPCX_REG_OFFSET_CHECK(scfg_reg, DEV_CTL4, 0x006);
NPCX_REG_OFFSET_CHECK(scfg_reg, DEVALT0, 0x010);
NPCX_REG_OFFSET_CHECK(scfg_reg, LV_GPIO_CTL0, 0x02A);
NPCX_REG_OFFSET_CHECK(scfg_reg, LV_GPIO_CTL0, 0x02a);
/* UART register structure check */
NPCX_REG_SIZE_CHECK(uart_reg, 0x027);
NPCX_REG_OFFSET_CHECK(uart_reg, UPSR, 0x00E);
NPCX_REG_OFFSET_CHECK(uart_reg, UPSR, 0x00e);
NPCX_REG_OFFSET_CHECK(uart_reg, UFTSTS, 0x020);
NPCX_REG_OFFSET_CHECK(uart_reg, UFRCTL, 0x026);
@ -51,51 +51,51 @@ NPCX_REG_OFFSET_CHECK(gpio_reg, PLOCK_CTL, 0x007);
NPCX_REG_SIZE_CHECK(espi_reg, 0x500);
NPCX_REG_OFFSET_CHECK(espi_reg, FLASHCFG, 0x034);
NPCX_REG_OFFSET_CHECK(espi_reg, VWEVMS, 0x140);
NPCX_REG_OFFSET_CHECK(espi_reg, VWCTL, 0x2FC);
NPCX_REG_OFFSET_CHECK(espi_reg, VWCTL, 0x2fc);
NPCX_REG_OFFSET_CHECK(espi_reg, OOBTXBUF, 0x380);
NPCX_REG_OFFSET_CHECK(espi_reg, OOBCTL_DIRECT, 0x3FC);
NPCX_REG_OFFSET_CHECK(espi_reg, OOBCTL_DIRECT, 0x3fc);
NPCX_REG_OFFSET_CHECK(espi_reg, FLASHTXBUF, 0x480);
NPCX_REG_OFFSET_CHECK(espi_reg, FLASHCTL_DIRECT, 0x4FC);
NPCX_REG_OFFSET_CHECK(espi_reg, FLASHCTL_DIRECT, 0x4fc);
/* MSWC register structure check */
NPCX_REG_SIZE_CHECK(mswc_reg, 0x030);
NPCX_REG_OFFSET_CHECK(mswc_reg, HCBAL, 0x008);
NPCX_REG_OFFSET_CHECK(mswc_reg, HCBAH, 0x00A);
NPCX_REG_OFFSET_CHECK(mswc_reg, SRID_CR, 0x01C);
NPCX_REG_OFFSET_CHECK(mswc_reg, HCBAH, 0x00a);
NPCX_REG_OFFSET_CHECK(mswc_reg, SRID_CR, 0x01c);
NPCX_REG_OFFSET_CHECK(mswc_reg, SID_CR, 0x020);
NPCX_REG_OFFSET_CHECK(mswc_reg, VW_SLPST1, 0x2E);
NPCX_REG_OFFSET_CHECK(mswc_reg, VW_SLPST1, 0x02e);
/* SHM register structure check */
NPCX_REG_SIZE_CHECK(shm_reg, 0x050);
NPCX_REG_OFFSET_CHECK(shm_reg, IMA_WIN_SIZE, 0x005);
NPCX_REG_OFFSET_CHECK(shm_reg, WIN_SIZE, 0x007);
NPCX_REG_OFFSET_CHECK(shm_reg, IMA_SEM, 0x00B);
NPCX_REG_OFFSET_CHECK(shm_reg, SHCFG, 0x00E);
NPCX_REG_OFFSET_CHECK(shm_reg, IMA_SEM, 0x00b);
NPCX_REG_OFFSET_CHECK(shm_reg, SHCFG, 0x00e);
NPCX_REG_OFFSET_CHECK(shm_reg, WIN1_WR_PROT, 0x010);
NPCX_REG_OFFSET_CHECK(shm_reg, IMA_WR_PROT, 0x016);
NPCX_REG_OFFSET_CHECK(shm_reg, WIN_BASE1, 0x020);
NPCX_REG_OFFSET_CHECK(shm_reg, WIN_BASE2, 0x024);
NPCX_REG_OFFSET_CHECK(shm_reg, RST_CFG, 0x03A);
NPCX_REG_OFFSET_CHECK(shm_reg, RST_CFG, 0x03a);
NPCX_REG_OFFSET_CHECK(shm_reg, DP80BUF, 0x040);
NPCX_REG_OFFSET_CHECK(shm_reg, DP80CTL, 0x044);
NPCX_REG_OFFSET_CHECK(shm_reg, HOFS_STS, 0x048);
NPCX_REG_OFFSET_CHECK(shm_reg, COFS1, 0x04C);
/* KBC register structure check */
NPCX_REG_SIZE_CHECK(kbc_reg, 0x00C);
NPCX_REG_OFFSET_CHECK(kbc_reg, HIKMDI, 0x00A);
NPCX_REG_OFFSET_CHECK(kbc_reg, SHIKMDI, 0x00B);
NPCX_REG_SIZE_CHECK(kbc_reg, 0x00c);
NPCX_REG_OFFSET_CHECK(kbc_reg, HIKMDI, 0x00a);
NPCX_REG_OFFSET_CHECK(kbc_reg, SHIKMDI, 0x00b);
/* PMCH register structure check */
NPCX_REG_SIZE_CHECK(pmch_reg, 0x012);
NPCX_REG_OFFSET_CHECK(pmch_reg, HIPMDO, 0x002);
NPCX_REG_OFFSET_CHECK(pmch_reg, HIPMDOC, 0x006);
NPCX_REG_OFFSET_CHECK(pmch_reg, HIPMDOM, 0x008);
NPCX_REG_OFFSET_CHECK(pmch_reg, HIPMDIC, 0x00A);
NPCX_REG_OFFSET_CHECK(pmch_reg, HIPMDIC, 0x00a);
NPCX_REG_OFFSET_CHECK(pmch_reg, HIPMIE, 0x010);
/* C2H register structure check */
NPCX_REG_SIZE_CHECK(c2h_reg, 0x00C);
NPCX_REG_SIZE_CHECK(c2h_reg, 0x00c);
NPCX_REG_OFFSET_CHECK(c2h_reg, LKSIOHA, 0x004);
NPCX_REG_OFFSET_CHECK(c2h_reg, CRSMAE, 0x008);
NPCX_REG_OFFSET_CHECK(c2h_reg, SIBCTRL, 0x00A);
NPCX_REG_OFFSET_CHECK(c2h_reg, SIBCTRL, 0x00a);