Bluetooth: Controller: Build hci_vendor.c also for simulation

The FICR is also modelled in simulation, but changing this
conditional compile was forgotten, so it was only being
built for real HW.
A test had provided its own version of this function so it would
avoid a runtime warning due to the lack of static address. But
this needs to be removed as it conflicts with the function
provided now always by the nordic controller SW.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>

subsys/bluetooth/controller/ll_sw/nordic/CMakeLists.txt

@@ -85,8 +85,7 @@ zephyr_library_sources_ifdef(
   ull/ull_iso_vendor.c
   )
 
-zephyr_library_sources_ifdef(
-  CONFIG_SOC_FAMILY_NORDIC_NRF
+zephyr_library_sources(
   hci/hci_vendor.c
   )
 

tests/bluetooth/df/common/src/hci_vendor_stub.c

@@ -1,25 +0,0 @@
-/*
- * Copyright (c) 2021 Nordic Semiconductor ASA
- *
- * SPDX-License-Identifier: Apache-2.0
- */
-
-#include <zephyr/bluetooth/addr.h>
-#include <zephyr/bluetooth/hci_vs.h>
-
-/**
- * @brief This is a stub of a function that provides static address.
- *
- * This function is defined to silent warning printed by Host during BT stack initialization due
- * to lack of static address stored in controller.
- */
-uint8_t hci_vendor_read_static_addr(struct bt_hci_vs_static_addr addrs[], uint8_t size)
-{
-	/* only one supported */
-	ARG_UNUSED(size);
-
-	/* Use some fake address, because it does not matter for test purposes */
-	(void)memset(addrs[0].ir, 0x01, sizeof(addrs[0].ir));
-
-	return 1;
-}

tests/bluetooth/df/connection_cte_tx_params/CMakeLists.txt

@@ -10,7 +10,6 @@ project(bluetooth_df_connection_cte_tx_params)
 FILE(GLOB app_sources src/*.c)
 SET(common_sources ${CMAKE_CURRENT_SOURCE_DIR}/../common/src/bt_common.c
 		   ${CMAKE_CURRENT_SOURCE_DIR}/../common/src/bt_conn_common.c
-		   ${CMAKE_CURRENT_SOURCE_DIR}/../common/src/hci_vendor_stub.c
 		   ${CMAKE_CURRENT_SOURCE_DIR}/../common/src/radio_df_stub.c)
 
 target_sources(app PRIVATE ${common_sources} ${app_sources})