patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

kernel: threads: Do not use string compare instead of bit ops

Browse source 
Remove converting bit to string and comparing the string instead of
ready helpers. The "Check if thread is in use" seems to check only
that parameters state_buf and sizeof(state_buf) not zero.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
This commit is contained in:
Andrei Emeltchenko 2023-12-13 13:30:18 +02:00 committed by Carles Cufí
parent 7ed7a8c272
commit 9d3a3e96e1
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
kernel/dynamic.c
View file

@ -7,6 +7,7 @@
#include "kernel_internal.h"
#include <zephyr/kernel.h>
#include <ksched.h>
#include <zephyr/kernel/thread_stack.h>
#include <zephyr/logging/log.h>
#include <zephyr/sys/bitarray.h>
@ -120,20 +121,14 @@ static void dyn_cb(const struct k_thread *thread, void *user_data)
int z_impl_k_thread_stack_free(k_thread_stack_t *stack)
{
char state_buf[16] = {0};
struct dyn_cb_data data = {.stack = stack};
/* Get a possible tid associated with stack */
k_thread_foreach(dyn_cb, &data);
if (data.tid != NULL) {
/* Check if thread is in use */
if (k_thread_state_str(data.tid, state_buf, sizeof(state_buf)) != state_buf) {
LOG_ERR("tid %p is invalid!", data.tid);
return -EINVAL;
}
if (!(strcmp("dummy", state_buf) == 0) || (strcmp("dead", state_buf) == 0)) {
if (!(z_is_thread_state_set(data.tid, _THREAD_DUMMY) ||
z_is_thread_state_set(data.tid, _THREAD_DEAD))) {
LOG_ERR("tid %p is in use!", data.tid);
return -EBUSY;
}