patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

timer: ambiq_stimer: Correct set_timeout's delta clock calculation

Browse source 
In sys_clock_set_timeout(), input "ticks" is used to compute next
timeout point, Ambiq's STimer API used to sets next timeout has input
parameter as ui32Delta, which inside the API is using
"this value to add to the STimer counter and load into the comparator
register" according to its spec, thus the this delta clock is
almost equivalent to input "ticks"'s concept, and is not related to
last_count, it should be computed directly from input "ticks".
This correction fixes the test case failure at
zephyr\tests\kernel\tickless\tickless_concept.

Signed-off-by: Bryan Zhu <bzhu@ambiq.com>
This commit is contained in:
Bryan Zhu 2023-12-19 09:21:27 +08:00 committed by Carles Cufí
parent 46b0d036e2
commit a417392f76
1 changed files with 8 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/timer/ambiq_stimer.c
View file

@ -80,24 +80,16 @@ void sys_clock_set_timeout(int32_t ticks, bool idle)
return;
}
if (ticks == K_TICKS_FOREVER) {
return;
}
ticks = MIN(MAX_TICKS, ticks);
/* If tick is 0, set delta cyc to MIN_DELAY to trigger tick isr asap */
uint32_t cyc = MAX(ticks * CYC_PER_TICK, MIN_DELAY);
k_spinlock_key_t key = k_spin_lock(&g_lock);
uint64_t now = am_hal_stimer_counter_get();
uint32_t adj, cyc = ticks * CYC_PER_TICK;
/* Round up to next tick boundary. */
adj = (uint32_t)(now - g_last_count) + (CYC_PER_TICK - 1);
if (cyc <= MAX_CYCLES - adj) {
cyc += adj;
} else {
cyc = MAX_CYCLES;
}
cyc = (cyc / CYC_PER_TICK) * CYC_PER_TICK;
if ((int32_t)(cyc + g_last_count - now) < MIN_DELAY) {
cyc += CYC_PER_TICK;
}
am_hal_stimer_compare_delta_set(0, cyc);
k_spin_unlock(&g_lock, key);