patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: route: Do not dereference NULL pointer while getting next hop

Browse source 
Assertions should only be used to check invariants.  Things that may
change value in runtime are better left to proper checks.

Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
This commit is contained in:
Leandro Pereira 2018-02-27 15:46:10 -08:00 committed by Anas Nashif
parent 5bdb1c2fe7
commit a53f525830
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subsys/net/ip/route.c
View file

@ -595,12 +595,14 @@ struct in6_addr *net_route_get_nexthop(struct net_route_entry *route)
}
ipv6_nbr_data = net_ipv6_nbr_data(nexthop_route->nbr);
NET_ASSERT(ipv6_nbr_data);
if (ipv6_nbr_data) {
addr = &ipv6_nbr_data->addr;
NET_ASSERT(addr);
addr = &ipv6_nbr_data->addr;
NET_ASSERT(addr);
return addr;
return addr;
} else {
NET_ERR("could not get neighbor data from next hop");
}
}
return NULL;