patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

doc: project roles: Further finetune language

Browse source 
More details about roles and responsibilities and reviewer expectations.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
This commit is contained in:
Anas Nashif 2023-10-11 19:50:24 +00:00 committed by Carles Cufí
parent 8663449055
commit a6bfbedbf5
2 changed files with 27 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
doc/contribute/contributor_expectations.rst
View file

@ -261,6 +261,9 @@ the steps below:
.. _Architecture Working Group: https://github.com/zephyrproject-rtos/zephyr/wiki/Architecture-Working-Group
.. _reviewer-expectations:
Reviewer Expectations
#####################
@ -270,7 +273,7 @@ Reviewer Expectations
- The Zephyr Project recognizes that reviewers and maintainers have limited
bandwidth. As a reviewer, prioritize review requests in the following order:
#. PRs related to items in the `Zephyr Release Plan`_ or those targetting
#. PRs related to items in the `Zephyr Release Plan`_ or those targeting
the next release during the stabilization period (after RC1).
#. PRs where the reviewer has requested blocking changes.
#. PRs assigned to the reviewer as the area maintainer.
@ -300,6 +303,11 @@ Reviewer Expectations
they address all non-blocking comments. PR authors should acknowledge every
review comment in some way, even if it's just with an emoticon.
- Reviewers shall be *clear* and *concise* what changes they are requesting when the
"Request Changes" option is used. Requested changes shall be in the scope of
the PR in question and following the contribution and style guidelines of the
project.
.. _Code of Conduct: https://github.com/zephyrproject-rtos/zephyr/blob/main/CODE_OF_CONDUCT.md
.. _Zephyr Release Plan: https://github.com/orgs/zephyrproject-rtos/projects/13

26
doc/project/project_roles.rst
View file

@ -67,9 +67,9 @@ template <new?assignees=&labels=Role+Nomination&template=006_nomination.md&title
Contributors granted the Triage permission level are permitted to add reviewers
to a pull request and can be added as a reviewer by other GitHub users.
Contributor votes on pull requests are not counted with respect to accepting and
merging a pull request. However, Contributors comments and requested changes
should still be considered by the pull request author.
Contributor change requests or approval on pull requests are not counted with
respect to accepting and merging a pull request. However, Contributors comments
and requested changes should still be considered by the pull request author.
Collaborator
++++++++++++
@ -95,7 +95,14 @@ Contributors are promoted to the Collaborator role by adding the GitHub user
name to one or more ``collaborators`` sections of the :ref:`maintainers_file` in
the Zephyr repository.
Collaborator votes on pull requests can block or approve the pull request.
Collaborator change requests on pull requests should
be addressed by the original submitter. In cases where the changes requested do
not follow the :ref:`expectations <reviewer-expectations>` and the guidelines
of the project or in cases of disagreement, it is the responsibility of the
assignee to advance the review process and resolve any disagreements.
Collaborator approval of pull requests are counted toward the minimum required
approvals needed to merge a PR. Other criteria for merging may apply.
Maintainer
++++++++++
@ -121,7 +128,8 @@ Contributors or Collaborators are promoted to the Maintainer role by adding the
GitHub user name to one or more ``maintainers`` sections of the
:ref:`maintainers_file` in the Zephyr repository.
Maintainer votes on pull requests can block or approve the pull request.
Maintainer approval of pull requests are counted toward the minimum
required approvals needed to merge a PR. Other criteria for merging may apply.
Role Retirement
###############
@ -149,9 +157,11 @@ Assignees are set either automatically based on the code being changed or set
by the other Maintainers, the Release Engineering team can set an assignee when
the latter is not possible.
* Right to dismiss stale reviews and seek reviews from additional maintainers,
developers and contributors
* Right to block pull requests from being merged
* Right to dismiss stale and unrelated reviews or reviews not following
:ref:`expectations <reviewer-expectations>` from reviewers and seek reviews
from additional maintainers, developers and contributors
* Right to block pull requests from being merged until issues or changes
requested are addressed
* Responsibility to re-assign a pull request if they are the original submitter
of the code
* Responsibility to drive the pull request to a mergeable state