patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

subsys/usb: Fix use of 'abs' in computing when to report on_idle

Browse source 
idle_rate is uint8_t, sof_cnt is uint32_t. The result is uint32_t, which
is the wrong type for 'abs'. Explicitly cast idle_rate to uint32_t,
subtract sof_cnt and then explicitly cast to int32_t and then use abs,
storing the result in another int32_t which matches the return type for
abs.

This quiets clang warnings about passing unsigned values to abs.

Signed-off-by: Keith Packard <keithp@keithp.com>
This commit is contained in:
Keith Packard 2022-04-27 21:48:38 -07:00 committed by Stephanos Ioannidis
parent c034050bba
commit abac6ccfaf
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subsys/usb/device/class/hid/core.c
View file

@ -327,8 +327,8 @@ void hid_sof_handler(struct hid_device_info *dev_data)
continue;
}
uint32_t diff = abs(dev_data->idle_rate[i] * 4U -
dev_data->sof_cnt[i]);
int32_t diff = abs((int32_t) ((uint32_t) dev_data->idle_rate[i] * 4U -
dev_data->sof_cnt[i]));
if (diff < 2 && reported == false) {
dev_data->sof_cnt[i] = 0U;