patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

i2c: gpio_i2c_switch: fix gpio api misuse

Browse source 
Use GPIO_OUTPUT_INACTIVE to initialize the pin so that the ACTIVE_LOW DT
flag is honored and use the gpio_pin_set_dt functions to set the
(logical) value of the pin instead of gpio_pin_configure_dt, that
tries to reconfigure the pin each time.

Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
This commit is contained in:
Fabio Baltieri 2023-11-09 19:04:13 +00:00 committed by Fabio Baltieri
parent 9a44f7f583
commit ac450be5c8
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/i2c/gpio_i2c_switch.c
View file

@ -51,13 +51,13 @@ static int gpio_i2c_switch_transfer(const struct device *dev, struct i2c_msg *ms
}
/* enable switch */
gpio_pin_configure_dt(&config->gpio, GPIO_OUTPUT_HIGH);
gpio_pin_set_dt(&config->gpio, 1);
k_busy_wait(GPIO_I2C_TOGGLE_DELAY_US);
res = i2c_transfer(config->bus, msgs, num_msgs, addr);
/* disable switch */
gpio_pin_configure_dt(&config->gpio, GPIO_OUTPUT_LOW);
gpio_pin_set_dt(&config->gpio, 0);
k_busy_wait(GPIO_I2C_TOGGLE_DELAY_US);
k_mutex_unlock(&data->lock);
@ -76,7 +76,7 @@ static int gpio_i2c_switch_init(const struct device *dev)
k_mutex_init(&data->lock);
return gpio_pin_configure_dt(&config->gpio, GPIO_OUTPUT_LOW);
return gpio_pin_configure_dt(&config->gpio, GPIO_OUTPUT_INACTIVE);
}
#define DEFINE_GPIO_I2C_SWITCH(inst) \