patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: wifi: esp_at: fix ssid_len calucation for AP query.

Browse source 
The driver seems to be designed to use the very last byte of the
buffer(scan, connect), so null terminating the status query
might have unintended consequences.
However we should not use strlen to determine the ssid_len,
to avoid depending on the following buffer(bssid) to be zeroed.
Related to CID 316354

Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
This commit is contained in:
Thomas Stranger 2024-02-11 20:05:35 +01:00 committed by Maureen Helm
parent 29d7f9fa73
commit ade3c72a35
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/wifi/esp_at/esp.c
View file

@ -7,6 +7,9 @@
#define DT_DRV_COMPAT espressif_esp_at
#undef _POSIX_C_SOURCE
#define _POSIX_C_SOURCE 200809L
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(wifi_esp_at, CONFIG_WIFI_LOG_LEVEL);
@ -16,6 +19,7 @@ LOG_MODULE_REGISTER(wifi_esp_at, CONFIG_WIFI_LOG_LEVEL);
#include <zephyr/device.h>
#include <zephyr/init.h>
#include <stdlib.h>
#include <string.h>
#include <zephyr/drivers/gpio.h>
#include <zephyr/drivers/uart.h>
@ -319,7 +323,7 @@ MODEM_CMD_DEFINE(on_cmd_cwjap)
}
strncpy(status->ssid, ssid, sizeof(status->ssid));
status->ssid_len = strlen(status->ssid);
status->ssid_len = strnlen(status->ssid, sizeof(status->ssid));
err = net_bytes_from_str(status->bssid, sizeof(status->bssid), bssid);
if (err) {