From b4094ea6c1bd5ef752c6a59f6df3d1b57428a8a1 Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Mon, 16 Sep 2019 14:54:02 +0200 Subject: [PATCH] shell: kconfig: Fix wrong UART_SHELL_ON_DEV_NAME value due to typo The $(dt_chosen_label) preprocessor function should be passed $(DT_CHOSEN_Z_SHELL_UART), not $(UART_SHELL_ON_DEV_NAME). DT_CHOSEN_Z_SHELL_UART is set right before the Kconfig symbol definition, to work around the comma in 'zephyr,shell-uart'. The Kconfig preprocessor functions are defined in scripts/kconfig/kconfigfunctions.py. Fixes: #19178 Signed-off-by: Ulf Magnusson --- subsys/shell/Kconfig.backends | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subsys/shell/Kconfig.backends b/subsys/shell/Kconfig.backends index c97a322f57..80dba27a70 100644 --- a/subsys/shell/Kconfig.backends +++ b/subsys/shell/Kconfig.backends @@ -35,7 +35,7 @@ DT_CHOSEN_Z_SHELL_UART := zephyr,shell-uart config UART_SHELL_ON_DEV_NAME string "Device Name of UART Device for SHELL_BACKEND_SERIAL" - default "$(dt_chosen_label,$(UART_SHELL_ON_DEV_NAME))" if HAS_DTS + default "$(dt_chosen_label,$(DT_CHOSEN_Z_SHELL_UART))" if HAS_DTS default "UART_0" help This option specifies the name of UART device to be used for the