patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: gnss: nmea_generic: some fixes/improvements

Browse source 
- Configure a UART TX buffer; the backend would otherwise assert in
its configuration or (if the asserts are off) miserably fail when
trying to send anything to the GNSS modem.
- Fine tune the UART RX buffer size and make it depend on whether
satellite data is received.
- Remove unused k_spinlock.
- Make declaration of Kconfig items dependent on GNSS_NMEA_GENERIC
conditional.

Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
This commit is contained in:
Tomi Fontanilles 2024-04-22 16:56:46 +03:00 committed by Anas Nashif
parent 21efdc23c9
commit b4c8d47536
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/gnss/Kconfig.generic
View file

@ -15,6 +15,8 @@ config GNSS_NMEA_GENERIC
help
Generic NMEA based GNSS device.
if GNSS_NMEA_GENERIC
config GNSS_NMEA_GENERIC_SATELLITES_COUNT
int "Maximum satellite count"
depends on GNSS_SATELLITES
@ -24,3 +26,5 @@ config GNSS_NMEA_GENERIC_SATELLITES_COUNT
the GNSS device. This does not affect the number of devices that the
device is actually tracking, just how many of those can be reported
in the satellites callback.
endif

12
drivers/gnss/gnss_nmea_generic.c
View file

@ -22,9 +22,8 @@
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(gnss_nmea_generic, CONFIG_GNSS_LOG_LEVEL);
#define DT_DRV_COMPAT gnss_nmea_generic
#define UART_RECV_BUF_SZ 128
#define UART_RX_BUF_SZ (256 + IS_ENABLED(CONFIG_GNSS_SATELLITES) * 512)
#define UART_TX_BUF_SZ 64
#define CHAT_RECV_BUF_SZ 256
#define CHAT_ARGV_SZ 32
@ -42,14 +41,13 @@ struct gnss_nmea_generic_data {
/* UART backend */
struct modem_pipe *uart_pipe;
struct modem_backend_uart uart_backend;
uint8_t uart_backend_receive_buf[UART_RECV_BUF_SZ];
uint8_t uart_backend_receive_buf[UART_RX_BUF_SZ];
uint8_t uart_backend_transmit_buf[UART_TX_BUF_SZ];
/* Modem chat */
struct modem_chat chat;
uint8_t chat_receive_buf[CHAT_RECV_BUF_SZ];
uint8_t *chat_argv[CHAT_ARGV_SZ];
struct k_spinlock lock;
};
MODEM_CHAT_MATCHES_DEFINE(unsol_matches,
@ -110,6 +108,8 @@ static void gnss_nmea_generic_init_pipe(const struct device *dev)
.uart = cfg->uart,
.receive_buf = data->uart_backend_receive_buf,
.receive_buf_size = sizeof(data->uart_backend_receive_buf),
.transmit_buf = data->uart_backend_transmit_buf,
.transmit_buf_size = sizeof(data->uart_backend_transmit_buf),
};
data->uart_pipe = modem_backend_uart_init(&data->uart_backend, &uart_backend_config);