patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

net: icmp: Don't report error on ICMP messages w/o handler

Browse source 
ICMPv4/6 modules print error when ICMP message handling fails, which
includes no message handler registered. This is a bit problematic, as
there are many ICMP messages that Zephyr does not process, and every
time such a message is received, an error log is printed (which wasn't
the case before ICMP rework).

Restore the old behavior (no log on unrecognized ICMP message) by
explicitly filtering out ENOENT error code from printing error. That
way, log will only be printed if an error occured within the actual
message handler.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2024-01-25 15:23:13 +01:00 committed by Fabio Baltieri
parent 2545c747b8
commit b8556d0d79
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subsys/net/ip/icmpv4.c
View file

@ -639,7 +639,7 @@ enum net_verdict net_icmpv4_input(struct net_pkt *pkt,
net_stats_update_icmp_recv(net_pkt_iface(pkt));
ret = net_icmp_call_ipv4_handlers(pkt, ip_hdr, icmp_hdr);
if (ret < 0) {
if (ret < 0 && ret != -ENOENT) {
NET_ERR("ICMPv4 handling failure (%d)", ret);
}

2
subsys/net/ip/icmpv6.c
View file

@ -364,7 +364,7 @@ enum net_verdict net_icmpv6_input(struct net_pkt *pkt,
net_stats_update_icmp_recv(net_pkt_iface(pkt));
ret = net_icmp_call_ipv6_handlers(pkt, ip_hdr, icmp_hdr);
if (ret < 0) {
if (ret < 0 && ret != -ENOENT) {
NET_ERR("ICMPv6 handling failure (%d)", ret);
}